This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
feat: Save partial project progress during project creation #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlittle
reviewed
Apr 17, 2019
| // If we are creating a new project check to see if there is a partial | ||
| // project already created in local storage | ||
| if (this.props.match.url === "/projects/create") { | ||
| const projectJson = localStorage.getItem(projectFormTempKey); |
There was a problem hiding this comment.
do we ever need to clear this? Perhaps after it gets created?
There was a problem hiding this comment.
nvm, just saw that down below 🙂
|
LGTM - this was annoying behavior. nice fix. |
pjlittle
approved these changes
Apr 17, 2019
wbreza
added a commit
that referenced
this pull request
Apr 29, 2019
This adds functionality to persist partial project information when creating a new project. Right now when creating a new connection inline within the create project flow and returning to the create project screen your partial project information is lost. Partial form progress is now saved into local storage and bound when returning to the form. Resolves #758
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to persist partial project information when creating a new project. Right now when creating a new connection inline within the create project flow and returning to the create project screen your partial project information is lost. Partial form progress is now saved into local storage and bound when returning to the form.
Resolves #758