Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

feat: CNTK Export Provider #771

Merged
merged 4 commits into from
Apr 17, 2019
Merged

feat: CNTK Export Provider #771

merged 4 commits into from
Apr 17, 2019

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Apr 17, 2019

Adds CNTK export provider into v2

Resolves #754

Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -289,6 +289,10 @@ export const spanish: IAppStrings = {
tagged: "Solo activos etiquetados",
},
},
testTrainSplit: {
title: "Prueba/tren Split",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La división para entrenar y comprobar

@@ -289,6 +289,10 @@ export const spanish: IAppStrings = {
tagged: "Solo activos etiquetados",
},
},
testTrainSplit: {
title: "Prueba/tren Split",
description: "La división del tren de prueba que se utilizará para los datos exportados",
Copy link
Contributor

@tbarlow12 tbarlow12 Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La división de datos para utilizar entre el entrenamiento y la comprobación

Copy link
Contributor

@JacopoMangiavacchi JacopoMangiavacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but haven't found time to test the output yet

@pjlittle
Copy link
Collaborator

Yeah looks good - like Jacopo, I was wondering if anyone had tried using the output w/ CNTK or on the DSVM.

@wbreza
Copy link
Contributor Author

wbreza commented Apr 17, 2019

@JacopoMangiavacchi @pjlittle - I didn't load up the data into any ML pipeline / tool, but compared the output from a project in v1 vs v2 and is the same. I'll complete the merge for now but will also attempt to load training data into some model.

@wbreza wbreza merged commit 929c91d into develop Apr 17, 2019
wbreza added a commit that referenced this pull request Apr 29, 2019
Adds CNTK export provider into v2

Resolves #754
@PIC123 PIC123 deleted the wabrez/cntk-export-provider branch August 20, 2019 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants