Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

fix: Fix display of tag color picker #782

Merged
merged 4 commits into from
Apr 26, 2019

Conversation

tbarlow12
Copy link
Contributor

  • Updates the TagInput component to use the TagInputItem type instead of RefObject<TagInputItem>
  • Adds several unit tests of uncovered areas for TagInput

@tbarlow12 tbarlow12 requested review from wbreza and PIC123 April 25, 2019 20:46
Copy link
Contributor

@JacopoMangiavacchi JacopoMangiavacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Please verify the tag operation still work as expected after a tag rename / delete operation.

@tbarlow12 tbarlow12 merged commit ee6cc77 into microsoft:develop Apr 26, 2019
@tbarlow12
Copy link
Contributor Author

tbarlow12 commented Apr 26, 2019

Resolves [AB#18368]

@tbarlow12 tbarlow12 deleted the fix-tag-color-picker branch April 26, 2019 15:32
wbreza pushed a commit that referenced this pull request Apr 29, 2019
Resolves issue of tag color picker not being shown on alt-click or color-click + edit button. Also adds several tests for increased test coverage of tagInput.tsx
elizabethhalper pushed a commit to riagarg/VoTT that referenced this pull request Aug 20, 2019
author Wallace Breza <[email protected]> 1556573964 -0700
committer Elizabeth Halper <[email protected]> 1566326008 -0700

parent e4ee4cd
author Wallace Breza <[email protected]> 1556573964 -0700
committer Elizabeth Halper <[email protected]> 1566326007 -0700

parent e4ee4cd
author Wallace Breza <[email protected]> 1556573964 -0700
committer Elizabeth Halper <[email protected]> 1566326004 -0700

parent e4ee4cd
author Wallace Breza <[email protected]> 1556573964 -0700
committer Elizabeth Halper <[email protected]> 1566325986 -0700

parent e4ee4cd
author Wallace Breza <[email protected]> 1556573964 -0700
committer Elizabeth Halper <[email protected]> 1566325973 -0700

Release 2.1.0 (microsoft#790)

Updates package version and changelog for 2.1.0 release

changed line

refactor: Remove editor footer

Dummy commit to kick off build again

doc: Add bug & feature templates (microsoft#780)

Adds bug and feature github templates

Create CODE_OF_CONDUCT.md (microsoft#779)

Adds code of conduct

docs: updates to readme and changelog (microsoft#781)

Minor updates and corrections to the main readme and changelog.

fix: Fix display of tag color picker (microsoft#782)

Resolves issue of tag color picker not being shown on alt-click or color-click + edit button. Also adds several tests for increased test coverage of tagInput.tsx

feat: Add CSV Exporter (microsoft#757)

Adds CSV export provider

fix: change method for alloc string to buffer (microsoft#777)

String.length is not appropriate for calculating buffer size
when non-alphabet letter is included in content.
Change the method Buffer.alloc to Buffer.from as directed by the nodejs document.

fix: Updates backwards compat & fixes cntk export image bug (microsoft#789)

Fixes an issue where the images exported out of a video file were missing file extension for video projects.

Release 2.1.0 (microsoft#790)

Updates package version and changelog for 2.1.0 release

changed line

rebase upstream dev
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants