Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

fix: Update export options for pascalVOC rename #788

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Apr 29, 2019

When loading a v2.0.0 project that was configured to use tensorflowPascalVOC export provider it fails on project load and get stuck in an infinite loop

Fix
Adds a check during project load to update the export options if project was using previous pascalVOC name.

@wbreza wbreza changed the base branch from master to develop April 29, 2019 18:27
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #788 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #788      +/-   ##
==========================================
+ Coverage    87.89%   87.9%   +0.01%     
==========================================
  Files          129     129              
  Lines         4839    4844       +5     
  Branches       920     922       +2     
==========================================
+ Hits          4253    4258       +5     
  Misses         584     584              
  Partials         2       2
Impacted Files Coverage Δ
src/services/projectService.ts 85.71% <100%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba3130...79142a2. Read the comment docs.

Copy link
Contributor

@JacopoMangiavacchi JacopoMangiavacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wbreza wbreza merged commit c38daca into develop Apr 29, 2019
@wbreza wbreza deleted the wabrez/update-export-options branch April 29, 2019 18:48
wbreza added a commit that referenced this pull request Apr 29, 2019
Adds a check during project load to update the export options if project was using previous pascalVOC name.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants