Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

fix: Revert horizontal asset bar #881

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Conversation

wbreza
Copy link
Contributor

@wbreza wbreza commented Aug 23, 2019

The horizontal asset bar looks more visually appealing on the bottom and it also opens up more real estate for the main editing surface.

However, it also reduces the overall usability of the app. The vertical scrolling behavior on the moues wheel no longer works and the keyboard shortcut hot keys are inverted.

Let's revert this change for now until we are able to overcome these critical usability requirements.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #881 into develop will decrease coverage by 0.35%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #881      +/-   ##
===========================================
- Coverage    88.15%   87.79%   -0.36%     
===========================================
  Files          130      130              
  Lines         4878     4876       -2     
  Branches       903      903              
===========================================
- Hits          4300     4281      -19     
- Misses         576      593      +17     
  Partials         2        2
Impacted Files Coverage Δ
...c/react/components/pages/editorPage/editorPage.tsx 83.33% <100%> (ø) ⬆️
...eact/components/pages/editorPage/editorSideBar.tsx 39.58% <37.5%> (-36.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f9f65...68e9edd. Read the comment docs.

Copy link
Contributor

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would be nice to see if we can figure out a way to allow for other layouts

@wbreza wbreza merged commit 90577ca into develop Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants