Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributing link in the issue template #2261

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Fix contributing link in the issue template #2261

merged 1 commit into from
Jul 10, 2017

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Jun 26, 2017

Hi,

this Pull Request just fixed the link to the contributing instructions in the ISSUE_TEMPLATE.md.

Currently it points to: https://github.com/CONTRIBUTING.md on the issue submission form.

Please note that this issue only shows up in the issue submission form. The normal view in the repo works good before and after the path.

See here:
image

@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@benhillis
Copy link
Member

The existing link correctly brings me to https://github.com/Microsoft/BashOnWindows/blob/master/CONTRIBUTING.md, Is the link not working for you?

@benhillis benhillis closed this Jul 5, 2017
@zero-24
Copy link
Contributor Author

zero-24 commented Jul 5, 2017

@benhillis please go to this page: https://github.com/Microsoft/BashOnWindows/issues/new and switch to the "preview" tab. Than please try the link again. I can confirm that if you view it directly in the repo it is working. Please reopen the pull request.

@zero-24
Copy link
Contributor Author

zero-24 commented Jul 10, 2017

@benhillis Please take a look here again. This is fixing a valid issue.

You can also check this issue here: #2291

And this output of the web console:
image

Thanks

@benhillis
Copy link
Member

Thanks for the additional information, I'll merge this in.

@benhillis benhillis reopened this Jul 10, 2017
@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@benhillis benhillis merged commit aa50a57 into microsoft:master Jul 10, 2017
@zero-24
Copy link
Contributor Author

zero-24 commented Jul 10, 2017

Thanks 👍

@zero-24 zero-24 deleted the contributing branch July 10, 2017 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants