Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX Functional test pattern - exercising sample app's UIViewController within a functional test #1771

Merged
merged 3 commits into from
Jan 25, 2017
Merged

UX Functional test pattern - exercising sample app's UIViewController within a functional test #1771

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c91705
UX Functional test pattern - exercising sample app's UIViewController…
oliversa-msft Jan 23, 2017
ca1a4e3
Code review feedback
oliversa-msft Jan 24, 2017
830399e
Code review feedback
oliversa-msft Jan 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions build/Tests/FunctionalTests/FunctionalTests.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
<AdditionalDependencies>Wex.Logger.lib;Wex.Common.lib;TE.Common.lib;libdispatch.lib;UIKit.Xaml.lib;%(AdditionalDependencies)</AdditionalDependencies>
</Link>
<ClangCompile>
<IncludePaths>..\..\..\Frameworks\include;..\..\..\Frameworks\UIKit.Xaml;..\..\..\include\xplat;..\..\..\tests\frameworks\include;..\..\..\tests\functionaltests;..\..\..\tests\frameworks\gtest;..\..\..\tests\frameworks\gtest\include;..\..\..\deps\prebuilt\include\TAEF;..\..\..\samples\XAMLCatalog;%(AdditionalIncludeDirectories)</IncludePaths>
<IncludePaths>..\..\..\Frameworks\include;..\..\..\Frameworks\UIKit.Xaml;..\..\..\include\xplat;..\..\..\tests\frameworks\include;..\..\..\tests\functionaltests;..\..\..\tests\frameworks\gtest;..\..\..\tests\frameworks\gtest\include;..\..\..\deps\prebuilt\include\TAEF;..\..\..\samples\XAMLCatalog\XAMLCatalog;%(AdditionalIncludeDirectories)</IncludePaths>
<CompileAs>CompileAsObjCpp</CompileAs>
<OtherCPlusPlusFlags>-fmsvc-real-char -Wdeprecated-declarations</OtherCPlusPlusFlags>
<PreprocessorDefinitions>_CRT_SECURE_NO_WARNINGS;DEBUG=1;FUNCTIONAL_TEST_FRAMEWORK</PreprocessorDefinitions>
Expand Down Expand Up @@ -159,7 +159,7 @@
<AdditionalDependencies>Wex.Logger.lib;Wex.Common.lib;TE.Common.lib;libdispatch.lib;UIKit.Xaml.lib;%(AdditionalDependencies)</AdditionalDependencies>
</Link>
<ClangCompile>
<IncludePaths>..\..\..\Frameworks\include;..\..\..\Frameworks\UIKit.Xaml;..\..\..\include\xplat;..\..\..\tests\frameworks\include;..\..\..\tests\functionaltests;..\..\..\tests\frameworks\gtest;..\..\..\tests\frameworks\gtest\include;..\..\..\deps\prebuilt\include\TAEF;..\..\..\samples\XAMLCatalog;%(AdditionalIncludeDirectories)</IncludePaths>
<IncludePaths>..\..\..\Frameworks\include;..\..\..\Frameworks\UIKit.Xaml;..\..\..\include\xplat;..\..\..\tests\frameworks\include;..\..\..\tests\functionaltests;..\..\..\tests\frameworks\gtest;..\..\..\tests\frameworks\gtest\include;..\..\..\deps\prebuilt\include\TAEF;..\..\..\samples\XAMLCatalog\XAMLCatalog;%(AdditionalIncludeDirectories)</IncludePaths>
<CompileAs>CompileAsObjCpp</CompileAs>
<OtherCPlusPlusFlags>-fmsvc-real-char -Wdeprecated-declarations</OtherCPlusPlusFlags>
<PreprocessorDefinitions>_CRT_SECURE_NO_WARNINGS;DEBUG=1;FUNCTIONAL_TEST_FRAMEWORK</PreprocessorDefinitions>
Expand Down Expand Up @@ -187,7 +187,7 @@
<AdditionalDependencies>Wex.Logger.lib;Wex.Common.lib;TE.Common.lib;libdispatch.lib;UIKit.Xaml.lib;%(AdditionalDependencies)</AdditionalDependencies>
</Link>
<ClangCompile>
<IncludePaths>..\..\..\Frameworks\include;..\..\..\Frameworks\UIKit.Xaml;..\..\..\include\xplat;..\..\..\tests\frameworks\include;..\..\..\tests\functionaltests;..\..\..\tests\frameworks\gtest;..\..\..\tests\frameworks\gtest\include;..\..\..\deps\prebuilt\include\TAEF;..\..\..\samples\XAMLCatalog;%(AdditionalIncludeDirectories)</IncludePaths>
<IncludePaths>..\..\..\Frameworks\include;..\..\..\Frameworks\UIKit.Xaml;..\..\..\include\xplat;..\..\..\tests\frameworks\include;..\..\..\tests\functionaltests;..\..\..\tests\frameworks\gtest;..\..\..\tests\frameworks\gtest\include;..\..\..\deps\prebuilt\include\TAEF;..\..\..\samples\XAMLCatalog\XAMLCatalog;%(AdditionalIncludeDirectories)</IncludePaths>
<CompileAs>CompileAsObjCpp</CompileAs>
<OtherCPlusPlusFlags>-fmsvc-real-char -Wdeprecated-declarations</OtherCPlusPlusFlags>
<PreprocessorDefinitions>_CRT_SECURE_NO_WARNINGS;DEBUG=1;FUNCTIONAL_TEST_FRAMEWORK</PreprocessorDefinitions>
Expand Down Expand Up @@ -219,7 +219,7 @@
<AdditionalDependencies>Wex.Logger.lib;Wex.Common.lib;TE.Common.lib;libdispatch.lib;UIKit.Xaml.lib;%(AdditionalDependencies)</AdditionalDependencies>
</Link>
<ClangCompile>
<IncludePaths>..\..\..\Frameworks\include;..\..\..\Frameworks\UIKit.Xaml;..\..\..\include\xplat;..\..\..\tests\frameworks\include;..\..\..\tests\functionaltests;..\..\..\tests\frameworks\gtest;..\..\..\tests\frameworks\gtest\include;..\..\..\deps\prebuilt\include\TAEF;..\..\..\samples\XAMLCatalog;%(AdditionalIncludeDirectories)</IncludePaths>
<IncludePaths>..\..\..\Frameworks\include;..\..\..\Frameworks\UIKit.Xaml;..\..\..\include\xplat;..\..\..\tests\frameworks\include;..\..\..\tests\functionaltests;..\..\..\tests\frameworks\gtest;..\..\..\tests\frameworks\gtest\include;..\..\..\deps\prebuilt\include\TAEF;..\..\..\samples\XAMLCatalog\XAMLCatalog;%(AdditionalIncludeDirectories)</IncludePaths>
<CompileAs>CompileAsObjCpp</CompileAs>
<OtherCPlusPlusFlags>-fmsvc-real-char -Wdeprecated-declarations</OtherCPlusPlusFlags>
<PreprocessorDefinitions>_CRT_SECURE_NO_WARNINGS;DEBUG=1;FUNCTIONAL_TEST_FRAMEWORK</PreprocessorDefinitions>
Expand All @@ -243,9 +243,11 @@
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\AppDelegate.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\MainViewController.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\FunctionalTestHelpers.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\UXTestHelpers.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\AssetsLibraryTests\AssetsLibraryTestHelpers.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\MenuTableViewController.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIButtonViewController.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIKitControls\UIButtonViewController.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIKitControls\UIButtonWithControlsViewController.h" />
</ItemGroup>
<ItemGroup>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\AppDelegate.mm">
Expand All @@ -255,6 +257,7 @@
<ObjectiveCARC>true</ObjectiveCARC>
</ClangCompile>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\FunctionalTestHelpers.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\UXTestHelpers.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\NSURLConnection.mm">
<ObjectiveCARC>true</ObjectiveCARC>
</ClangCompile>
Expand All @@ -270,7 +273,8 @@
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\UIApplicationTests.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\ToastNotificationTests.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\MenuTableViewController.m" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIButtonViewController.m" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIKitControls\UIButtonViewController.m" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIKitControls\UIButtonWithControlsViewController.m" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\UIKitTests\UIViewTests.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\UIKitTests\UIActivityIndicatorTests.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\UIKitTests\UIButtonTests.mm" />
Expand Down
35 changes: 25 additions & 10 deletions build/Tests/FunctionalTests/FunctionalTests.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
<Filter Include="Tests\UIKitTests">
<UniqueIdentifier>{34bd5c19-86ba-4661-bbb6-63295c1ca90f}</UniqueIdentifier>
</Filter>
<Filter Include="Tests\ViewControllers">
<UniqueIdentifier>{4c703c5d-0c21-4205-9e17-55fed2d45b67}</UniqueIdentifier>
</Filter>
</ItemGroup>
<ItemGroup>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\pch.h" />
Expand All @@ -33,14 +36,20 @@
<Filter>Framework</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\FunctionalTestHelpers.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\UXTestHelpers.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\AssetsLibraryTests\AssetsLibraryTestHelpers.h">
<Filter>Tests\AssetsLibraryTests</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIButtonViewController.h">
<Filter>Tests\UIKitTests</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\AppDelegate.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\MainViewController.h" />
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\MenuTableViewController.h">
<Filter>Tests\UIKitTests</Filter>
<Filter>Tests\ViewControllers</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIKitControls\UIButtonViewController.h">
<Filter>Tests\ViewControllers</Filter>
</ClInclude>
<ClInclude Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIKitControls\UIButtonWithControlsViewController.h">
<Filter>Tests\ViewControllers</Filter>
</ClInclude>
</ItemGroup>
<ItemGroup>
Expand All @@ -52,6 +61,7 @@
</ItemGroup>
<ItemGroup>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\FunctionalTestHelpers.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\UXTestHelpers.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\SampleTest.mm">
<Filter>Tests</Filter>
</ClangCompile>
Expand Down Expand Up @@ -109,12 +119,6 @@
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\UIKitTests\UIButtonTests.mm">
<Filter>Tests\UIKitTests</Filter>
</ClangCompile>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIButtonViewController.m">
<Filter>Tests\UIKitTests</Filter>
</ClangCompile>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\MenuTableViewController.m">
<Filter>Tests\UIKitTests</Filter>
</ClangCompile>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\UIKitTests\UIActivityIndicatorTests.mm">
<Filter>Tests\UIKitTests</Filter>
</ClangCompile>
Expand All @@ -130,6 +134,17 @@
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\UIKitTests\UIViewTests.mm">
<Filter>Tests\UIKitTests</Filter>
</ClangCompile>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\AppDelegate.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\MainViewController.mm" />
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\MenuTableViewController.m">
<Filter>Tests\ViewControllers</Filter>
</ClangCompile>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIKitControls\UIButtonViewController.m">
<Filter>Tests\ViewControllers</Filter>
</ClangCompile>
<ClangCompile Include="$(MSBuildThisFileDirectory)..\..\..\samples\XAMLCatalog\XAMLCatalog\UIKitControls\UIButtonWithControlsViewController.m">
<Filter>Tests\ViewControllers</Filter>
</ClangCompile>
</ItemGroup>
<ItemGroup>
<Xml Include="$(MSBuildThisFileDirectory)..\..\..\tests\functionaltests\Tests\NSURL.AppxManifest.xml">
Expand Down
30 changes: 15 additions & 15 deletions samples/XAMLCatalog/XAMLCatalog-WinStore10.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 14
VisualStudioVersion = 14.0.22823.1
MinimumVisualStudioVersion = 10.0.40219.1
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "XAMLCatalog", "XAMLCatalog", "{73A8D974-FFEC-4C22-9A79-56FE8D646D46}"
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "XAMLCatalog", "XAMLCatalog", "{FD57C970-6D9B-4AC7-BBBA-C589B2EA41BF}"
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "XAMLCatalog", "XAMLCatalog.vsimporter\XAMLCatalog-WinStore10\XAMLCatalog.vcxproj", "{A2D70D6C-657B-4071-83FC-5425BA8164B3}"
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "XAMLCatalog", "XAMLCatalog.vsimporter\XAMLCatalog-WinStore10\XAMLCatalog.vcxproj", "{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}"
EndProject
Global
GlobalSection(SharedMSBuildProjectFiles) = preSolution
Expand All @@ -16,23 +16,23 @@ Global
Release|Win32 = Release|Win32
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Debug|ARM.ActiveCfg = Debug|ARM
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Debug|ARM.Build.0 = Debug|ARM
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Debug|ARM.Deploy.0 = Debug|ARM
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Debug|Win32.ActiveCfg = Debug|Win32
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Debug|Win32.Build.0 = Debug|Win32
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Debug|Win32.Deploy.0 = Debug|Win32
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Release|ARM.ActiveCfg = Release|ARM
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Release|ARM.Build.0 = Release|ARM
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Release|ARM.Deploy.0 = Release|ARM
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Release|Win32.ActiveCfg = Release|Win32
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Release|Win32.Build.0 = Release|Win32
{A2D70D6C-657B-4071-83FC-5425BA8164B3}.Release|Win32.Deploy.0 = Release|Win32
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Debug|ARM.ActiveCfg = Debug|ARM
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Debug|ARM.Build.0 = Debug|ARM
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Debug|ARM.Deploy.0 = Debug|ARM
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Debug|Win32.ActiveCfg = Debug|Win32
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Debug|Win32.Build.0 = Debug|Win32
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Debug|Win32.Deploy.0 = Debug|Win32
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Release|ARM.ActiveCfg = Release|ARM
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Release|ARM.Build.0 = Release|ARM
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Release|ARM.Deploy.0 = Release|ARM
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Release|Win32.ActiveCfg = Release|Win32
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Release|Win32.Build.0 = Release|Win32
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0}.Release|Win32.Deploy.0 = Release|Win32
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
GlobalSection(NestedProjects) = preSolution
{A2D70D6C-657B-4071-83FC-5425BA8164B3} = {73A8D974-FFEC-4C22-9A79-56FE8D646D46}
{D51F1FE7-DDDB-44C8-A77D-8901FFE9F5E0} = {FD57C970-6D9B-4AC7-BBBA-C589B2EA41BF}
EndGlobalSection
EndGlobal
6 changes: 3 additions & 3 deletions samples/XAMLCatalog/XAMLCatalog.vsimporter/XAMLCatalog-WinStore10/Package.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
IgnorableNamespaces="uap mp">

<Identity
Name="22d1821d-adee-4387-9878-038a210b92b0"
Name="610e2818-92fa-4f57-b41f-702cfd837520"
Publisher="CN=islandwood"
Version="1.0.0.0" />

<mp:PhoneIdentity PhoneProductId="22d1821d-adee-4387-9878-038a210b92b0" PhonePublisherId="00000000-0000-0000-0000-000000000000"/>
<mp:PhoneIdentity PhoneProductId="610e2818-92fa-4f57-b41f-702cfd837520" PhonePublisherId="00000000-0000-0000-0000-000000000000"/>

<Properties>
<DisplayName>XAMLCatalog</DisplayName>
<PublisherDisplayName>jaredh</PublisherDisplayName>
<PublisherDisplayName>oliversa</PublisherDisplayName>
Copy link
Contributor

@yiyang-msft yiyang-msft Jan 23, 2017 •
edited by oliversa-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure worthwhile to check in these changes. #WontFix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was automatically populated with the re-import. I prefer to keep the autogen portion and not manually revert it.

In reply to: 97386296 [](ancestors = 97386296)

<Logo>Assets\StoreLogo.png</Logo>
</Properties>

Expand Down
14 changes: 7 additions & 7 deletions ...es/XAMLCatalog/XAMLCatalog.vsimporter/XAMLCatalog-WinStore10/XAMLCatalog-Debug-xcvars.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ PRODUCT_BUNDLE_IDENTIFIER = Microsoft.XAMLCatalog
PRODUCT_NAME = XAMLCatalog
PRODUCT_TYPE = com.apple.product-type.application
PROJECT = XAMLCatalog
PROJECT_DIR = I:/enl/vso_1_WinObjC/samples/XAMLCatalog
PROJECT_FILE_PATH = I:\enl\vso_1_WinObjC\samples\XAMLCatalog\XAMLCatalog.xcodeproj
PROJECT_DIR = E:/GIT_REPOS/winobjc/samples/XAMLCatalog
PROJECT_FILE_PATH = E:\GIT_REPOS\winobjc\samples\XAMLCatalog\XAMLCatalog.xcodeproj
Copy link
Member

@tadam-msft tadam-msft Jan 24, 2017 •
edited by oliversa-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these machine specific changes get checked in?
#Pending

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, every time you use VSIMPORTER, these changes are automatically made on your behalf. We could revert them, as Yi suggested, but it's going to resurface each time someone else makes a change.

In reply to: 97601767 [](ancestors = 97601767)

PROJECT_NAME = XAMLCatalog
PROJECT_TEMP_DIR = sbuild/XAMLCatalog.sbuild
PROJECT_TEMP_ROOT = sbuild
PUBLIC_HEADERS_FOLDER_PATH = XAMLCatalog.app/Public
SDKROOT = I:/enl/vso_1_WinObjC
SOURCE_ROOT = I:/enl/vso_1_WinObjC/samples/XAMLCatalog
SRCROOT = I:/enl/vso_1_WinObjC/samples/XAMLCatalog
SDKROOT = E:/GIT_REPOS/winobjc
SOURCE_ROOT = E:/GIT_REPOS/winobjc/samples/XAMLCatalog
Copy link
Contributor

@yiyang-msft yiyang-msft Jan 23, 2017 •
edited by oliversa-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E:/GIT_REPOS/winobjc/ [](start = 14, length = 21)

also this file. seemed related to different user config. should we check this file in at all? #WontFix

SRCROOT = E:/GIT_REPOS/winobjc/samples/XAMLCatalog
SYMROOT = sbuild
TARGETED_DEVICE_FAMILY = 1,2
TARGETNAME = XAMLCatalog
Expand All @@ -103,9 +103,9 @@ TARGET_SDKVERSION = 5.0
TARGET_TEMP_DIR = sbuild/XAMLCatalog.sbuild/Debug-iphoneos/XAMLCatalog.sbuild
TEMP_DIR = sbuild/XAMLCatalog.sbuild/Debug-iphoneos/XAMLCatalog.sbuild
UNLOCALIZED_RESOURCES_FOLDER_PATH = XAMLCatalog.app
USER = jaredh
USER = oliversa
USER_HEADER_SEARCH_PATHS =
USE_HEADERMAP = YES
WARNING_CFLAGS =
WARNING_LDFLAGS =
WINOBJC_SDK_ROOT = I:/enl/vso_1_WinObjC
WINOBJC_SDK_ROOT = E:/GIT_REPOS/winobjc
14 changes: 7 additions & 7 deletions .../XAMLCatalog/XAMLCatalog.vsimporter/XAMLCatalog-WinStore10/XAMLCatalog-Release-xcvars.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,15 @@ PRODUCT_BUNDLE_IDENTIFIER = Microsoft.XAMLCatalog
PRODUCT_NAME = XAMLCatalog
PRODUCT_TYPE = com.apple.product-type.application
PROJECT = XAMLCatalog
PROJECT_DIR = I:/enl/vso_1_WinObjC/samples/XAMLCatalog
PROJECT_FILE_PATH = I:\enl\vso_1_WinObjC\samples\XAMLCatalog\XAMLCatalog.xcodeproj
PROJECT_DIR = E:/GIT_REPOS/winobjc/samples/XAMLCatalog
PROJECT_FILE_PATH = E:\GIT_REPOS\winobjc\samples\XAMLCatalog\XAMLCatalog.xcodeproj
PROJECT_NAME = XAMLCatalog
PROJECT_TEMP_DIR = sbuild/XAMLCatalog.sbuild
PROJECT_TEMP_ROOT = sbuild
PUBLIC_HEADERS_FOLDER_PATH = XAMLCatalog.app/Public
SDKROOT = I:/enl/vso_1_WinObjC
SOURCE_ROOT = I:/enl/vso_1_WinObjC/samples/XAMLCatalog
SRCROOT = I:/enl/vso_1_WinObjC/samples/XAMLCatalog
SDKROOT = E:/GIT_REPOS/winobjc
Copy link
Contributor

@yiyang-msft yiyang-msft Jan 23, 2017 •
edited by oliversa-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GIT_REPOS [](start = 13, length = 9)

same here. #WontFix

SOURCE_ROOT = E:/GIT_REPOS/winobjc/samples/XAMLCatalog
SRCROOT = E:/GIT_REPOS/winobjc/samples/XAMLCatalog
SYMROOT = sbuild
TARGETED_DEVICE_FAMILY = 1,2
TARGETNAME = XAMLCatalog
Expand All @@ -102,10 +102,10 @@ TARGET_SDKVERSION = 5.0
TARGET_TEMP_DIR = sbuild/XAMLCatalog.sbuild/Release-iphoneos/XAMLCatalog.sbuild
TEMP_DIR = sbuild/XAMLCatalog.sbuild/Release-iphoneos/XAMLCatalog.sbuild
UNLOCALIZED_RESOURCES_FOLDER_PATH = XAMLCatalog.app
USER = jaredh
USER = oliversa
USER_HEADER_SEARCH_PATHS =
USE_HEADERMAP = YES
VALIDATE_PRODUCT = YES
WARNING_CFLAGS =
WARNING_LDFLAGS =
WINOBJC_SDK_ROOT = I:/enl/vso_1_WinObjC
WINOBJC_SDK_ROOT = E:/GIT_REPOS/winobjc
Loading