Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CTLine and CTRunGetImageBounds #1991

Merged
merged 2 commits into from
Feb 18, 2017
Merged

Implement CTLine and CTRunGetImageBounds #1991

merged 2 commits into from
Feb 18, 2017

Conversation

aballway
Copy link
Contributor

Fixes #1981

DHowett-MSFT
DHowett-MSFT reviewed Feb 16, 2017
View reviewed changes
Frameworks/include/CppUtils.h
@@ -36,7 +36,7 @@ std::basic_ostream<T>& operator<<(std::basic_ostream<T>& os, const CFRange& rang

#pragma region CGPoint
inline bool operator==(const CGPoint& lhs, const CGPoint& rhs) {
return ((std::abs(lhs.x - rhs.x) < 0.00001) && (std::abs(lhs.y - rhs.y) < 0.00001));
return lhs.x == rhs.x && lhs.y == rhs.y;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will almost certainly make tests fail on ARM. We had these set up for a reason. What's up?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Interesting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed on ARM

@aballway
Copy link
Contributor Author

Leading, which is some added space above a line typesetters use for multiline text, is not part of the image bounds.
There was a bug in CTRunGetTypographicBounds for ranges with location > 0

@aballway aballway merged commit 1a10b46 into microsoft:develop Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT left review comments

@rajsesh rajsesh rajsesh approved these changes

@MSFTFox MSFTFox MSFTFox approved these changes

@msft-Jeyaram msft-Jeyaram msft-Jeyaram approved these changes

@ms-jihua ms-jihua Awaiting requested review from ms-jihua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aballway @DHowett-MSFT @rajsesh @MSFTFox @msft-Jeyaram @msftclas