Implementation of ClearRect with masking support #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the second iteration is the change from the last CR. @DHowett-MSFT please take a look at the new heart art :) |
|
Looks like git lfs is failing on build machines |
DHowett-MSFT
reviewed
Mar 2, 2017
|
|
||
| HRESULT __CGContext::ClearRect(CGRect rect) { | ||
| PushBeginDraw(); | ||
| auto endDraw = wil::ScopeExit([this]() { PopEndDraw(); }); |
There was a problem hiding this comment.
prefer return PopEndDraw() at the end; otherwise, we lose the HRESULT from EndDraw.
DHowett-MSFT
approved these changes
Mar 2, 2017
rajsesh
approved these changes
Mar 2, 2017
|
so on the build machine, the generated image for one of the tests differ by a pixel :( |
|
Verbal extra sign off by @DHowett-MSFT merging . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.