Fix bug with changing focus and apply changes from #157 to SplitButton page, Closes #200

[marcelwgn]

Fix a bug where hitting control+b and similar commands will result in navigating the app with focus becoming nearly impossible

Description

Changed the event that was used since the previous event for text colorization would create an endless loop.

I also added the code that was introduced to the RichEditBox in #157 so that the same behavior does not occur in the SplitButton sample.

Motivation and Context

Closes #200

How Has This Been Tested?

Tested manually by starting application, visiting the RichEditBox on the SplitButton page and hitting control+b. After that I was able to successfully navigate to other commands using tab navigation.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[stmoy]

Philosophical question for you both (@YuliKl @chingucoding) - this change introduces a bunch of codebehind to the sample, but this code isn't included in the sample code shown on the page. Should it be? Or is this just a bunch of "glue" to help make the sample work as expected?

[YuliKl]

Philosophical question for you both (@YuliKl @chingucoding) - this change introduces a bunch of codebehind to the sample, but this code isn't included in the sample code shown on the page. Should it be? Or is this just a bunch of "glue" to help make the sample work as expected?

I definitely think of the code as "glue". It has nothing to do with SplitButton per se, just makes the coloring scenario work better.

[marcelwgn]

I agree with @YuliKl, most of the code is just "glue" to deal with the text changing its color.

One thing we might do is create an empty event listener function. In the sample, the SplitButton "uses" the myColorButton_Click function. Maybe we could add that function with a comment inside saying something like "Handling button click".
However I don't really think that it would be that helpful to just have a C# code block with an empty function. What do you think about that @stmoy and @YuliKl ?

[stmoy]

However I don't really think that it would be that helpful to just have a C# code block with an empty function. What do you think about that @stmoy and @YuliKl ?

Agreed, I don't think it's super useful. I also agree with the overall direction as Yulia described. Net result: no changes needed.