Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where cut and paste would not correctly work on SplitButtonPage and RichEditBoxPage #294

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

marcelwgn
Copy link
Collaborator

Description

Fixed bug #286 by detecting when user has changed text upon REB gaining focus, to not interfere with that.

Motivation and Context

Fixes #286

How Has This Been Tested?

Tested by reproducing steps in #286:

  1. Launch XAML Control Gallery app.
  2. Navigate to "SplitButton" or "RichEditBox" in All controls and activate it.
  3. In the textbox (or last sample of RichEditBox page), select the text written and right click to invoke the context menu and select "Cut" menu item.
  4. Again invoke the context menu and activate "Paste" menu item and observe.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@stmoy stmoy merged commit a31f67a into microsoft:master Dec 12, 2019
@stmoy stmoy mentioned this pull request Mar 4, 2020
13 tasks
@marcelwgn marcelwgn deleted the cut-paste-crash-reb branch June 18, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes on activating "Paste" from the context menu in SplitButton
3 participants