Update samples that use the RichEditBox #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmoy
reviewed
Aug 7, 2020
| @@ -22,7 +22,7 @@ | |||
| </Grid.ColumnDefinitions> | |||
|
|
|||
| <muxc:SplitButton x:Name="myColorButton" AutomationProperties.Name="Font color" Padding="0" MinHeight="0" MinWidth="0" VerticalAlignment="Top" Click="myColorButton_Click"> | |||
| <Rectangle x:Name="CurrentColor" Width="{StaticResource SwatchSize}" Height="{StaticResource SwatchSize}" Fill="Black" Margin="0"/> | |||
| <Rectangle x:Name="CurrentColor" Width="{StaticResource SwatchSize}" Height="{StaticResource SwatchSize}" Fill="Gray" Margin="0"/> | |||
There was a problem hiding this comment.
Instead of Gray, could we make the default some obviously obnoxious color like Teal? I'm worried that Gray will make the control look like it's in the Disabled state, but it's not. If we choose an obviously customized color, it'll help indicate that a non-default color has been set.
There was a problem hiding this comment.
Yeah, gray wasn't a great choice. I've switched to green now as it is one of the colors we had in the selection, that also is fairly visible in both themes, and isn't to aggressive to the eye.
stmoy
approved these changes
Aug 7, 2020
13 tasks
bpulliam
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Revert PR #157 * Fix samples * Switch default to green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few changes:
I am not happy with the default foreground being gray, however this is the easy approach to fix the issue with black text on black background in dark theme. Having those depend on the current theme will make the samples definitely more complex, that is why I opted out of doing this for now.
Motivation and Context
Update samples as the recent changes to the RichEditBox control broke them.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes