Skip to content

Commit

Permalink
Remove Timestamp from VSIX version due to WinAppSDK NuGet Version Upd…
Browse files Browse the repository at this point in the history
…ate (#2560)

* remove timestamp because version should be unique now

* comment
  • Loading branch information
kythant authored Jun 3, 2022
1 parent 722e408 commit d1d6daa
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions dev/VSIX/Extension/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,15 @@
</PropertyGroup>
<PropertyGroup Condition="'$(VSIXVersion)' == ''">
<!-- Use 3-part Windows App SDK version, less any tagging suffix -->
<!--
WindowsAppSDK release versions now have a timestamp as part of the patch
and a revision count making very release versions unique. This avoids
version sequencing issues between experimental and stable/preview versions
that might otherwise have the same version number, since VSIX does not
support preview tags or other mechanisms to distinguish.
-->
<VSIXVersion>$(WindowsAppSDKVersion)</VSIXVersion>
<VSIXVersion Condition="$(VSIXVersion.Contains(&quot;-&quot;))">$(VSIXVersion.Substring(0, $(VSIXVersion.IndexOf("-"))))</VSIXVersion>
<!--
Add a timestamp as part 4 of the version for uniqueness, and to ensure newer builds are newer
versions. Note that the timestamp is also included in release builds. This avoids version
sequencing issues between experimental and stable/preview versions that might otherwise have the same
version number, since VSIX does not support preview tags or other mechanisms to distinguish.
-->
<TimeSpan>$([System.Math]::Floor($([System.DateTime]::UtcNow.Subtract($([System.DateTime]::Parse('2020-01-01T00:00Z'))).TotalSeconds)))</TimeSpan>
<VSIXVersion>$(VSIXVersion).$(TimeSpan)</VSIXVersion>
</PropertyGroup>

<Target Name="GetVSIXVersion" Outputs="$(VSIXVersion)" />
Expand Down

0 comments on commit d1d6daa

Please sign in to comment.