Flow CsWinRT version from versions.props #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
BenJKuhn
approved these changes
Dec 17, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow CsWinRT version from versions.props
Notes:
Version.props in dev\MRTCore\build was removed because most of the versions properties there were unused. The only thing that uses it was dev\MRTCore\build\DownloadDotNetCoreSdk.ps1 so I've switch the path to use the version.props in eng/
dev\MRTCore\global.json also needs to be updated but I am not sure if there is a way to flow the sdk version number from version.props to there. I am going to leave this for now and investigate later why this global.json is used and possibly remove the need for it.
Maestro will make updates to version.details.xml and version.props for CsWinRT