39817966: [WinAppSDK 1.1] Unpackaged + self-contained Blank Project crashes at startup

[DrusTheAxe]

Undocked RegFree WinRT had a long-standing bug in ParseFileTag() where it retrieved the filename via xmlReader->GetValue() into a raw pointer and then used it AFTER calling xmlReader->Read(). That's a no-no -- GetValue returns a raw pointer to the current-context; you need to deep-copy if if you want to use it after you change the parser's current-context (e.g. by calling Read), as per https://docs.microsoft.com/en-us/previous-versions/windows/desktop/ms752870(v=vs.85)

Note

The pointer returned by GetValue is only valid until you move the reader to another node. When you move the reader to another node, XmlLite may reuse the memory referenced by the pointer. Therefore, you should not use the pointer after calling one of the following methods: Read, MoveToNextAttribute, MoveToFirstAttribute, MoveToAttributeByName, or MoveToElement. Although they do not move the reader, the following two methods will also make the pointer invalid: SetInput and IUnknown::Release. If you want to preserve the value that was returned in ppwszValue, you should make a deep copy.

The key phrase: When you move the reader to another node, XmlLite may reuse the memory referenced by the pointer. Therefore, you should not use the pointer after calling one of the following methods:...

This could coincidentally work if you had small RegFreeWinRT info in your manifest, but that was pure luck of memory layout.

This issue exists in URFW from before we forked copy. URFW should be likewise fixed, tracked per RegFreeWinRT support has bug in string handling that leads to failed DLL lookup #776

[DrusTheAxe]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).