AppNotificationContent Builder Core Features - part II #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loneursid
added
the
area-Notifications
ghost
added
the
loneursid
changed the title
loneursid
changed the title
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
loneursid
requested review from
sharath2727,
andrewleader,
danielayala94,
David-Quero and
hulumane
hulumane
reviewed
Aug 2, 2022
hulumane
reviewed
Aug 2, 2022
hulumane
reviewed
Aug 2, 2022
hulumane
reviewed
Aug 2, 2022
dev/AppNotifications/AppNotificationBuilder/AppNotificationBuilder.cpp
Outdated
Show resolved
Hide resolved
hulumane
reviewed
Aug 2, 2022
| @@ -316,7 +356,7 @@ namespace winrt::Microsoft::Windows::AppNotifications::Builder::implementation | |||
| xmlResult.reserve(c_maxAppNotificationPayload); | |||
|
|
|||
| // Build the button string and fill m_useButtonStyle | |||
| std::wstring buttons{ GetButtons() }; | |||
| std::wstring actions{ GetActions() }; | |||
There was a problem hiding this comment.
Would be awesome to have a comment on how a final string would look like with the payload.
There was a problem hiding this comment.
// <toast launch="action=AppNotificationClick;sequence={}">
// <visual>
// <binding template="ToastGeneric">
// <image placement="appLogoOverride" hint-crop="circle" src="image.png"/>
// <text>App Notification with Avatar Image< / text>
// <text>This is an example message using XML< / text>
// </binding>
// </visual>
// <actions>
// <input id="ComboBox" type="selection" defaultInput="yes">
// <selection id="yes" content="Going"/>
// <selection id="maybe" content="Maybe"/>
// <selection id="no" content="Decline"/>
// </input>
// <input id="textBox" type="text" placeHolderContent="reply"/>
// <action
// content="Send"
// imageUri="ms-appx://images/Icon.png"
// hint-inputId="textBox"
// arguments="action=reply&threadId=92187"/>
// <action
// content="Open App"
// arguments="action=OpenApp&sequence={}">
// </actions>
// </toast>
There was a problem hiding this comment.
I've tried to cobble something together with an image, some text, a combobox, a textbox and two buttons and I'm not convainced this would be useful.
I think i't better/easier to lookup the schema online when working in the builder.
I'm also concerned that this kind of comment will get out of sync quickly and become a maintenance nightmare.
I could create a unittest that creates an AppNotification simillar to this example comment. At least we know that this would never get out of sync with the code.
There was a problem hiding this comment.
Examples in the spec and documentation are welcome (and encouraged).
Not so useful as a comment.
Maybe useful as a doc-comment, if it can be small and meaningful.
hulumane
reviewed
Aug 2, 2022
hulumane
reviewed
Aug 2, 2022
hulumane
reviewed
Aug 2, 2022
hulumane
reviewed
Aug 2, 2022
dev/AppNotifications/AppNotificationBuilder/AppNotificationComboBox.cpp
Outdated
Show resolved
Hide resolved
hulumane
reviewed
Aug 2, 2022
dev/AppNotifications/AppNotificationBuilder/AppNotificationComboBox.h
Outdated
Show resolved
Hide resolved
added 2 commits
August 2, 2022 14:12
|
/azp run TransportPackage-Foundation-PR |
|
No pipelines are associated with this pull request. |
DrusTheAxe
reviewed
Aug 3, 2022
| THROW_HR_IF_MSG(E_INVALIDARG, id.empty(), "You must provide an id for the TextBox"); | ||
|
|
||
|
|
||
| m_textBoxList.push_back(wil::str_printf<std::wstring>(L"<input id='%ls' type='text'/>", id.c_str())); |
There was a problem hiding this comment.
Is ID restricted to never allow standard entities that need to be escaped?
standard entities are the gang of 5 -- greater-than, less-than, apostraphe, quote, ampersand
same comment applies in general - any data the Builder accepts that could contain these escape their content appropriately, e.g.
Bogus but representative example builder.AddButton("Ben & Jerry's") yields what?
<Button Name="Ben & Jerry's"> ==> not well-formed XML
<Button Name="Ben & Jerry's"> ==> well-formed XML
There was a problem hiding this comment.
Looks like it doesn't like " & <, but also it doesn't mind empty string. I am introducing an escape character map in my PR :#2805 @loneursid. We can add these to this map when my PR merges.
There was a problem hiding this comment.
We are using percent encoding for our special characters: https://developer.mozilla.org/en-US/docs/Glossary/percent-encoding
Go ahead and merge this PR when ready, I'll raise another PR regarding this issue since it would require more of a sweeping change in AppNotificationBuilder.
There was a problem hiding this comment.
Yeah, I'll do that. I'll merge this as is, since it's approved and the build is passing and raise a new PR to address nits from this and other PRs in the series
There was a problem hiding this comment.
There was a problem hiding this comment.
Addressing in: #2813
There was a problem hiding this comment.
Thanks @DrusTheAxe for catching this. It totally slipped past me.
Since we put anything that comes to us through the builder API into single quotes, technically, that the only character we need to escape, right? Or am I missing something?
DrusTheAxe
approved these changes
Aug 3, 2022
| } | ||
|
|
||
| return (result.empty()) ? result : wil::str_printf<std::wstring>(L"<actions>%ls</actions>", result.c_str()); |
There was a problem hiding this comment.
NIT: return result.empty() ? ...
| @@ -316,7 +356,7 @@ namespace winrt::Microsoft::Windows::AppNotifications::Builder::implementation | |||
| xmlResult.reserve(c_maxAppNotificationPayload); | |||
|
|
|||
| // Build the button string and fill m_useButtonStyle | |||
| std::wstring buttons{ GetButtons() }; | |||
| std::wstring actions{ GetActions() }; | |||
There was a problem hiding this comment.
Examples in the spec and documentation are welcome (and encouraged).
Not so useful as a comment.
Maybe useful as a doc-comment, if it can be small and meaningful.
| <ClCompile Include="$(MSBuildThisFileDirectory)AppNotificationTextProperties.cpp" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ClInclude Include="$(MSBuildThisFileDirectory)AppNotificationBuilder.h" /> | ||
| <ClInclude Include="$(MSBuildThisFileDirectory)AppNotificationBuilderUtility.h" /> | ||
| <ClInclude Include="$(MSBuildThisFileDirectory)AppNotificationButton.h" /> | ||
| <ClInclude Include="$(MSBuildThisFileDirectory)AppNotificationComboBox.h" /> | ||
| <ClInclude Include="$(MSBuildThisFileDirectory)AppNotificationTextProperties.h" /> | ||
| </ItemGroup> | ||
| </Project> |
There was a problem hiding this comment.
NIT: GitHub dislikes files ending without a new line
pmpurifoy
approved these changes
Aug 3, 2022
loneursid
added a commit
that referenced
this pull request
Aug 4, 2022
* FI develop into WNP_ContentBuilder_Prev1 (#2656) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <[email protected]> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <[email protected]> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> * User/erlangl/fi develop into feature (#2660) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <[email protected]> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <[email protected]> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> * FI develop into Content Builder feature branch (#2717) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report Co-authored-by: Hui Chen <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * FI develop into notification feature branch (#2733) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <[email protected]> Co-authored-by: Hui Chen <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Johan Laanstra <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> Co-authored-by: sachintaMSFT <[email protected]> Co-authored-by: Ben Kuhn <[email protected]> * AppNotificationBuilder features (#2786) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes Co-authored-by: eric langlois <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * AppNotificationContent Builder 1.2 spec (#2648) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update spec example with changes * Rename selectionMenu to ComboBox * Update AppNotificationBuilder-spec.md * Incorporate feedback * Update spec * Address feedback * Update spec * Update AppNotificationBuilder-spec.md * Address some more nits * Update AppNotificationBuilder-spec.md * Rename ButtonColor to AppNotificationButtonStyle * Committing PR renames and fixes * Address more spec comments * Rename AppNotificationContent->AppNotificationBuilder * Update AppNotificationBuilder-spec.md * Add Tag/Group * Update sample Co-authored-by: Alexander Sklar <[email protected]> * Update AppNotificationBuilder-spec.md * Rename ImageCrop->AppNotificationImageCrop * Fix spec samples * Reduce number of comments in idl * Add Is*Supported functions to limitations * Update Audio loop param to enum Co-authored-by: Alexander Sklar <[email protected]> * AppNotificationBuilder - Code Improvements (#2801) * Addressing nits from a previous PR * Uniform naming for tests * Addressing PR feedback * IsWindows... is the standard method for checking Windows version * nit Co-authored-by: Eric Langlois <[email protected]> * AppNotificationContent Builder Core Features - part II (#2760) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * AddTextBox * AddTextBox with PlaceHolderText and Title * consexpr all the things * code cleanup * AddComboBox * Improving validation for selection items * Input element limit is for textbox and comboBox combined * formating * struct isn't required unless we decide to do extra validation in the future * PR feedback * Check for non-empty IDs Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * AppNotificationBuilder - ProgressBar (#2780) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Initial implementation * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Fixing build break * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * Don't mix binding and value states * Code cleanup * Using printf as it is the norm for the builder * look proper * spacing * Reorder functions in idl to help github track changes properly * Keeping all progressBar tests together * PR feedback Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * Encoding/Decoding AppNotificationBuilder arguments (#2805) * Encode arguments * Argument encode/decode * Fix merge issues * Add Decode unit test * Use regex_replace instead * Address nits * Simplify encoding * Added XML escape encodings, need to improve Decode efficiency * Implement efficient decode * Update APITests.cpp * Add unit tests and encode all custom strings Co-authored-by: eric langlois <[email protected]> Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> Co-authored-by: Will Thant <[email protected]> Co-authored-by: Hui Chen <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Johan Laanstra <[email protected]> Co-authored-by: sachintaMSFT <[email protected]> Co-authored-by: Ben Kuhn <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Alexander Sklar <[email protected]> Co-authored-by: Paul Purifoy <[email protected]>
loneursid
added a commit
that referenced
this pull request
Aug 4, 2022
* FI develop into WNP_ContentBuilder_Prev1 (#2656) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <[email protected]> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <[email protected]> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> * User/erlangl/fi develop into feature (#2660) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <[email protected]> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <[email protected]> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> * FI develop into Content Builder feature branch (#2717) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report Co-authored-by: Hui Chen <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * FI develop into notification feature branch (#2733) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <[email protected]> Co-authored-by: Hui Chen <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Johan Laanstra <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> Co-authored-by: sachintaMSFT <[email protected]> Co-authored-by: Ben Kuhn <[email protected]> * AppNotificationBuilder features (#2786) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes Co-authored-by: eric langlois <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * AppNotificationContent Builder 1.2 spec (#2648) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update spec example with changes * Rename selectionMenu to ComboBox * Update AppNotificationBuilder-spec.md * Incorporate feedback * Update spec * Address feedback * Update spec * Update AppNotificationBuilder-spec.md * Address some more nits * Update AppNotificationBuilder-spec.md * Rename ButtonColor to AppNotificationButtonStyle * Committing PR renames and fixes * Address more spec comments * Rename AppNotificationContent->AppNotificationBuilder * Update AppNotificationBuilder-spec.md * Add Tag/Group * Update sample Co-authored-by: Alexander Sklar <[email protected]> * Update AppNotificationBuilder-spec.md * Rename ImageCrop->AppNotificationImageCrop * Fix spec samples * Reduce number of comments in idl * Add Is*Supported functions to limitations * Update Audio loop param to enum Co-authored-by: Alexander Sklar <[email protected]> * AppNotificationBuilder - Code Improvements (#2801) * Addressing nits from a previous PR * Uniform naming for tests * Addressing PR feedback * IsWindows... is the standard method for checking Windows version * nit Co-authored-by: Eric Langlois <[email protected]> * AppNotificationContent Builder Core Features - part II (#2760) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * AddTextBox * AddTextBox with PlaceHolderText and Title * consexpr all the things * code cleanup * AddComboBox * Improving validation for selection items * Input element limit is for textbox and comboBox combined * formating * struct isn't required unless we decide to do extra validation in the future * PR feedback * Check for non-empty IDs Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * Fixed timestamp parsing * AppNotificationBuilder - ProgressBar (#2780) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Initial implementation * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Fixing build break * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * Don't mix binding and value states * Code cleanup * Using printf as it is the norm for the builder * look proper * spacing * Reorder functions in idl to help github track changes properly * Keeping all progressBar tests together * PR feedback Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * Address nits * Fix build break in user/purifoypaul/TimestampFix (#2815) * AppNotificationBuilder - ProgressBar (#2780) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Initial implementation * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Fixing build break * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * Don't mix binding and value states * Code cleanup * Using printf as it is the norm for the builder * look proper * spacing * Reorder functions in idl to help github track changes properly * Keeping all progressBar tests together * PR feedback Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * namespace issues Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * Encoding/Decoding AppNotificationBuilder arguments (#2805) * Encode arguments * Argument encode/decode * Fix merge issues * Add Decode unit test * Use regex_replace instead * Address nits * Simplify encoding * Added XML escape encodings, need to improve Decode efficiency * Implement efficient decode * Update APITests.cpp * Add unit tests and encode all custom strings Co-authored-by: eric langlois <[email protected]> Co-authored-by: eric langlois <[email protected]> Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> Co-authored-by: Will Thant <[email protected]> Co-authored-by: Hui Chen <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Johan Laanstra <[email protected]> Co-authored-by: sachintaMSFT <[email protected]> Co-authored-by: Ben Kuhn <[email protected]> Co-authored-by: Alexander Sklar <[email protected]>
EricJohnson327
pushed a commit
that referenced
this pull request
Aug 24, 2022
* FI develop into WNP_ContentBuilder_Prev1 (#2656) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <[email protected]> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <[email protected]> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> * User/erlangl/fi develop into feature (#2660) * Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects * Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544) * Updating spec * Adressing comments * More changes Co-authored-by: Darren Hoehna <[email protected]> * Create a pipeline to automate FIs from main to develop (#2610) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608) * v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 * Telemetry char/string. AppData DataStore-1.0. * Retrieve the *Main* package's family name for AppData * Add/Remove the test Main package (DataStore) just like we do the test Framework * Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623) * Create tsaoptions.json * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Delete WindowsAppSDK-SourceAnalysis-job.yml * Delete WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-BinaryAnalysis-steps.yml * Create WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update ProjectReunion-CI.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update build-mrt.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Do a compiler options pass on all binaries contributing to WinAppSDK (#2629) Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4). Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details. Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it. This now standardizes all C++ projects to... * Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`) * Compile (debug): `/Od` * Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy` * Link (debug) `/DEBUG:FULL /INCREMENTAL` * Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF` https://task.ms/39994837 Foundation https://task.ms/39994852 MRTCore * Add standardized (project-wide) C++ compile and link options * Remove ARM support (not supported, but some ARM-conditional fragments weren't removed) * Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3 * Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options * Removed redundant <Optimization> from *vcxproj * Fixed warnings. Removed unnecessary delayload * Fixed some inconsistencies in project settings * Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load * Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors * Corrected some comments. Added the missing LTCG option * Changed LTCG from fast to normal * Updated FavorSizeOrSpeed to Size instead of Speed * Move LinkIncremental=false for Release builds to the top-level project-wide standard * Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently) * Fixed a comment * Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes * Removed options redundant with WindowsAppSDK.Build.Cpp.props * Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256). * Incorporated feedback * Overhaul NuGet versions to include "main" or "develop" (#2636) * Some old MSTest.pfx references were lingering (and now breaking things) (#2638) * Installation with System-Account doesn't work #2546 (#2565) * Installation with System-Account doesn't work #2546 Co-authored-by: Santosh Chintalapati <[email protected]> * Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640) * Fix the .NET SDK install script. * Remove .NET SDK version from global.json file. * Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline. * Update build-mrt.yml * Update DownloadDotNetCoreSdk.ps1 * Update global.json * Update WindowsAppSDK-BinaryAnalysis-steps.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update global.json * Update global.json * Update build-mrt.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-BuildDevProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildProject-Steps.yml * Update WindowsAppSDK-BuildSolution-Steps.yml * Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627) * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-BuildFoundation.yml * Update ProjectReunion-CI.yml * Update WindowsAppSDK-SourceAnalysis-job.yml * Update ProjectReunion-CI.yml * Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662) Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> * FI develop into Content Builder feature branch (#2717) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report Co-authored-by: Hui Chen <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * FI develop into notification feature branch (#2733) * update newtonsoft.json (#2688) * Introduce Register Overload for assets (#2596) * Introduce Register Overload for assets * Address comments * Add contractversion to register APi * Address comments * Add more examples of register API usage * Process doc for develop branch (#2383) * Add 1.1.2 tag to bug report * Properly ignore cleanup event if it can't be opened. (#2658) If we can't open the cleanup event, ignore it. Fixes ADO#38606299 * WindowsAppRuntimeInstaller.exe fails if newer version present Discussion #2708: [WindowsAppRuntime installation error: The package could not be installed because a higher version of this package is already installed](#2708) >Microsoft.WindowsAppRuntime.1.1_1000.516.2156.0_x64__8wekyb3d8bbwe Package deployment result : 0x80073d06 The package could not be installed because a higher version of this package is already installed. One or more install operations failed. Result: 0x80073d06 That's a bug - it should be OK, not an error. If v1.1.3 is installed and you run the installer for v1.1.2 we call packageManager.AddPackageAsync(...v1.1.2...) which returns 0x80073d06 == `ERROR_INSTALL_PACKAGE_DOWNGRADE` which is technically an error but functionally it's OK. If you build with 1.1.2 we don't require the runtime packages exactly match 1.1.2, but rather that there needs to be a package equal-or-higher than 1.1.2 (i.e. `>=1.1.2` not `==1.1.2`). If 1.1.3 is installed then all is well. Problem is we should be trapping `ERROR_INSTALL_PACKAGE_DOWNGRADE` and treating it as success. That's a bug on our part. https://task.ms/40411617 FYI: servicing-consider-1.1 = https://task.ms/40411679 * XCOPY command should be <COPY> to ensure execution (#2734) * XCOPY command should be XCOPY.EXE to ensure execution * Changed xcopy.exe to <Copy> * Fix typo * Put AccessControl files into transport package (#2751) * Add projection DLL * Put files into nuget package * Remove noexcept from Bootstrapper API so it can be used from C (#2750) * Remove noexcept from Bootstrapper API so it can be used from C * Switch noexcept to macro-style optional support per feedback * Update bug version to 1.1.3 (#2757) * <Copy> vs XCOPY.EXE -- Unbreak WindowsAppSDK-Nuget-Native.C.props Not-Build break 'build\native\WindowsAppSDK-Nuget-Native.C.props(32,13): error MSB4066: The attribute 'SourceFiles' in element is unrecognized.' -- Foundation builds but the aggregator doesn't. I suspect it's because of the command can't go in a , maybe something more complicated with the PostBuildEvent DependsOn a to do the copy...but I can't find any clear docs or net links clearly spelling it out so rather than fiddling while Rome burns I'm switching back to the original xcopy.exe solution to un-break the pipeline. Will follow up with folks to understand why the PR's build didn't pick this up * Updating reference to pick up license installation fix. (#2531) (#2764) Co-authored-by: Ben Kuhn <[email protected]> Co-authored-by: Hui Chen <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Johan Laanstra <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> Co-authored-by: sachintaMSFT <[email protected]> Co-authored-by: Ben Kuhn <[email protected]> * AppNotificationBuilder features (#2786) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes Co-authored-by: eric langlois <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * AppNotificationContent Builder 1.2 spec (#2648) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update AppNotificationBuilder-spec.md * Update spec example with changes * Rename selectionMenu to ComboBox * Update AppNotificationBuilder-spec.md * Incorporate feedback * Update spec * Address feedback * Update spec * Update AppNotificationBuilder-spec.md * Address some more nits * Update AppNotificationBuilder-spec.md * Rename ButtonColor to AppNotificationButtonStyle * Committing PR renames and fixes * Address more spec comments * Rename AppNotificationContent->AppNotificationBuilder * Update AppNotificationBuilder-spec.md * Add Tag/Group * Update sample Co-authored-by: Alexander Sklar <[email protected]> * Update AppNotificationBuilder-spec.md * Rename ImageCrop->AppNotificationImageCrop * Fix spec samples * Reduce number of comments in idl * Add Is*Supported functions to limitations * Update Audio loop param to enum Co-authored-by: Alexander Sklar <[email protected]> * AppNotificationBuilder - Code Improvements (#2801) * Addressing nits from a previous PR * Uniform naming for tests * Addressing PR feedback * IsWindows... is the standard method for checking Windows version * nit Co-authored-by: Eric Langlois <[email protected]> * AppNotificationContent Builder Core Features - part II (#2760) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * AddTextBox * AddTextBox with PlaceHolderText and Title * consexpr all the things * code cleanup * AddComboBox * Improving validation for selection items * Input element limit is for textbox and comboBox combined * formating * struct isn't required unless we decide to do extra validation in the future * PR feedback * Check for non-empty IDs Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * nits * new line to keep github happy * AppNotificationBuilder - ProgressBar (#2780) * First iteration * Fix formatting issues * Remove all references to toast * Add ProgressBar * Remove getters and other nits * Add XML outputs for all examples * Update examples and fix missing png * Add limitations * Add ArgumentSerializer and rename APIs * Fix some nits * Fix audio ctors * Add Deserializer functions and example * Apply review changes * Update AppNotificationBuilder-spec.md * Initial commit * Working on it * Add AppNotificationContent * Current impl * Working on unit tests * Added unit tests * Add Audio tests * Update APITests.cpp * Remove spec from PR * Rename AppNotification Builder API to match specs (#2766) * Renaming to match specs * Adding latest changes to specs * Code cleanup * Updating to reflect latest changes to the specs doc Co-authored-by: Eric Langlois <[email protected]> * Initial implementation * Update the spec with BuildNotification * Remove unused files * Add copyright to all files * Update AppNotificationBuilder.idl Adding copyright notice * Update pch.cpp Adding copyright notice * Update WindowsAppRuntime_DLL.vcxproj Removing references to fmt lib * Update packages.config Removing reference to fmt * Update AppNotificationBuilder.cpp Removing fmt since we won't be using and to unblock the build pipelines * Fixing build break * Addressing comments * Update error codes with messages * Add helper file * Add SetTimestamp impl * Add AppNotificationAudioLooping * Add IsSupported to attributes * Don't mix binding and value states * Code cleanup * Using printf as it is the norm for the builder * look proper * spacing * Reorder functions in idl to help github track changes properly * Keeping all progressBar tests together * PR feedback Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Eric Langlois <[email protected]> * Nits * Wrong error type * Nits * Spacing * Spacing Co-authored-by: James Parsons <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: Darren Hoehna <[email protected]> Co-authored-by: reunion-maestro-bot <[email protected]> Co-authored-by: Kyaw Thant <[email protected]> Co-authored-by: Howard Kapustein <[email protected]> Co-authored-by: alexlamtest <[email protected]> Co-authored-by: Jeff Genovy <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Eric Langlois <[email protected]> Co-authored-by: Ryan Shepherd <[email protected]> Co-authored-by: Will Thant <[email protected]> Co-authored-by: Hui Chen <[email protected]> Co-authored-by: Sharath Manchala <[email protected]> Co-authored-by: MikeHillberg <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Johan Laanstra <[email protected]> Co-authored-by: sachintaMSFT <[email protected]> Co-authored-by: Ben Kuhn <[email protected]> Co-authored-by: Paul Purifoy <[email protected]> Co-authored-by: Alexander Sklar <[email protected]> Co-authored-by: Paul Purifoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TextBox and ComboBox support to the AppNotificationBuilder