-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made a configurable constant #1819
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
===========================================
+ Coverage 36.95% 47.65% +10.69%
===========================================
Files 62 64 +2
Lines 6529 6837 +308
Branches 1447 1629 +182
===========================================
+ Hits 2413 3258 +845
+ Misses 3922 3310 -612
- Partials 194 269 +75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
would it be better to make the intro msg an argument instead of configurable constant? |
Co-authored-by: Joshua Kim <[email protected]>
@JieyuZ2 's suggestion can be addressed in a future PR if there are such needs. |
* Made a configurable constant * Fix typo Co-authored-by: Joshua Kim <[email protected]> --------- Co-authored-by: Joshua Kim <[email protected]>
Why are these changes needed?
This modification ensure that the introduction message is easily configurable and can be changed without altering the method's logic directly.
Related issue number
Closes #1690
Checks