Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoGen logging using Azure Cosmos DB #2760

Closed
wants to merge 17 commits into from
Closed

Conversation

wmwxwa
Copy link
Collaborator

@wmwxwa wmwxwa commented May 22, 2024

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

Attention: Patch coverage is 36.00000% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 13.85%. Comparing base (11d9336) to head (d811e6a).
Report is 10 commits behind head on main.

Files Patch % Lines
autogen/logger/cosmos_db_logger.py 36.47% 53 Missing and 1 partial ⚠️
autogen/logger/logger_factory.py 23.07% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2760       +/-   ##
===========================================
- Coverage   33.60%   13.85%   -19.75%     
===========================================
  Files          87       94        +7     
  Lines        9336     9527      +191     
  Branches     1987     2153      +166     
===========================================
- Hits         3137     1320     -1817     
- Misses       5933     8196     +2263     
+ Partials      266       11      -255     
Flag Coverage Δ
unittests 13.81% <36.00%> (-19.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wmwxwa wmwxwa requested a review from ekzhu May 22, 2024 17:15
@ekzhu
Copy link
Collaborator

ekzhu commented May 22, 2024

pls merge main for a CI fix

autogen/logger/__init__.py Outdated Show resolved Hide resolved
autogen/logger/cosmos_db_logger.py Outdated Show resolved Hide resolved
autogen/logger/cosmos_db_logger.py Outdated Show resolved Hide resolved
autogen/logger/cosmos_db_logger.py Outdated Show resolved Hide resolved
Hk669
Hk669 previously requested changes May 23, 2024
Copy link
Contributor

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can you add the tests for the

autogen/logger/cosmos_db_logger.py Show resolved Hide resolved
Copy link

gitguardian bot commented Jul 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Hk669
Copy link
Contributor

Hk669 commented Jul 28, 2024

please let us know, if this PR is still active? @wmwxwa

@jackgerrits jackgerrits dismissed Hk669’s stale review September 25, 2024 15:07

tests for logging component is not necessary

@jackgerrits
Copy link
Member

Ah I see the type checks are failing. Going to close this as it seems abandoned, @wmwxwa feel free to reopen if you wish to pursue this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants