-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookies from http session to web socket used by JupyterCodeExecutor #3312
Conversation
Thanks for the fix! Any way to add a test to "replicate" the error you saw with Kubernetes? Even a mock is good enough |
Thanks! In regards to testing, I think |
Why are these changes needed?
As noted in the below issue session affinity doesn't work as expected in a Kubernetes environment if the cookies aren't shared between the
http
andwss
requests. AutoGen is likely to try to establish a WS connection with a kernel that was created in a different pod.Related issue number
Closes #3311
Checks