Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the behavior of the method that loads llm_config and add new tests #3321

Open
wants to merge 3 commits into
base: 0.2
Choose a base branch
from

Conversation

umermansoor
Copy link
Contributor

@umermansoor umermansoor commented Aug 7, 2024

Why are these changes needed?

The current _validate_llm_config method contains redundancy and lacks comprehensive issue checks (for example, I was passing a string for tags and it didn't complain and required 30 minutes to debugging to figure out what the issue was). This improved version addresses these problems and includes 2 news tests.

Previous PR. Re-opening from upstream per Sonichi's comment.

Related issue number

Checks

@umermansoor
Copy link
Contributor Author

umermansoor commented Aug 7, 2024

There's an error on macOS build. A URL on Huggingface is timing out (working fine locally). I can take a look at it later tonight

@umermansoor
Copy link
Contributor Author

@sonichi closed the previous PR and reopened this one. Pls let me know if this is good.

@umermansoor
Copy link
Contributor Author

@sonichi @jtoy can you pls review this? It's been open for a while

@jackgerrits
Copy link
Member

Are you willing to update the PR to ensure all tests pass?

@ekzhu ekzhu changed the base branch from main to 0.2 October 2, 2024 18:26
@jackgerrits jackgerrits added the 0.2 Issues which were filed before re-arch to 0.4 label Oct 4, 2024
@rysweet
Copy link
Collaborator

rysweet commented Oct 10, 2024

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.

@rysweet rysweet added the awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which were filed before re-arch to 0.4 awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants