Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for changing system message role - this allows using o1-preview and o1-mini models #3591

Open
wants to merge 2 commits into
base: 0.2
Choose a base branch
from

Conversation

faisalil
Copy link

@faisalil faisalil commented Oct 1, 2024

Why are these changes needed?

To use the o1-preview and o1-mini models, we cannot send messages with role "system", to deal with this, I allowed controlling the role of the system message via an optional param.

Related issue number

N/A

Checks

@faisalil
Copy link
Author

faisalil commented Oct 1, 2024

@faisalil please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@faisalil
Copy link
Author

faisalil commented Oct 1, 2024

I see https://github.com/microsoft/autogen/pull/3530/files just now - happy to close this one if not needed

@jackgerrits
Copy link
Member

Thanks for the PR, we're still working on O1 support. Did you want to try out that other PR or provide feedback?

@ekzhu ekzhu changed the base branch from main to 0.2 October 2, 2024 18:23
@jackgerrits jackgerrits added the 0.2 Issues which were filed before re-arch to 0.4 label Oct 4, 2024
@rysweet
Copy link
Collaborator

rysweet commented Oct 10, 2024

This PR is against AutoGen 0.2. AutoGen 0.2 has been moved to the 0.2 branch. Please rebase your PR on the 0.2 branch or update it to work with the new AutoGen 0.4 that is now in main.

@rysweet rysweet added the awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which were filed before re-arch to 0.4 awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants