Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RAG gptassistant example notebook #694

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Add RAG gptassistant example notebook #694

merged 5 commits into from
Nov 16, 2023

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Nov 15, 2023 •
edited
Loading

Why are these changes needed?

Add a simple example per #641
Should be merged after merging #689

Related issue number

Checks

@gagb gagb linked an issue Nov 15, 2023 that may be closed by this pull request
Add RAG interpreter notebook for gptassistant #641
Closed
@gagb gagb marked this pull request as ready for review November 15, 2023 23:01
@gagb gagb added openai-assistant documentation Improvements or additions to documentation labels Nov 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e3723d) 28.85% compared to head (a12b07d) 28.85%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage   28.85%   28.85%           
=======================================
  Files          27       27           
  Lines        3393     3393           
  Branches      764      764           
=======================================
  Hits          979      979           
  Misses       2342     2342           
  Partials       72       72
Flag Coverage Δ
unittests 28.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb gagb requested a review from thinkall November 15, 2023 23:18
LeoLjl
LeoLjl approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@LeoLjl LeoLjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeoLjl
Copy link
Collaborator

LeoLjl commented Nov 16, 2023

Maybe the notebook can demonstrate how to get a file id from a local file?

@IANTHEREAL
Copy link
Collaborator

Maybe the notebook can demonstrate how to get a file id from a local file?

I have also been struggling with whether gpt assistant should support local file path, but autogen is not designed for file management...

IANTHEREAL
IANTHEREAL approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonichi sonichi mentioned this pull request Nov 16, 2023
Closed
sonichi
sonichi reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to this notebook in the website?
@qingyun-wu added links for previous notebooks.

@qingyun-wu
Copy link
Contributor

Add a link to this notebook in the website? @qingyun-wu added links for previous notebooks.

@gagb Links added to the website. And I left some comments in the notebook as well. Please check. Thank you!

@gagb
Copy link
Collaborator Author

gagb commented Nov 16, 2023

Add a link to this notebook in the website? @qingyun-wu added links for previous notebooks.

@gagb Links added to the website. And I left some comments in the notebook as well. Please check. Thank you!

@qingyun-wu updated the notebook with your feedback! Thank you!

@qingyun-wu qingyun-wu added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit fe00925 Nov 16, 2023
16 checks passed
@sonichi sonichi deleted the 641-add-rag-interpreter-notebook-for-gptassistant branch November 16, 2023 20:28
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@gagb @qingyun-wu
Add RAG gptassistant example notebook (microsoft#694)
39fb143 
* Add RAG gptassistant example notebook

* add notebook links

* Update notebook md

---------

Co-authored-by: Qingyun Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonichi sonichi sonichi left review comments

@LeoLjl LeoLjl LeoLjl approved these changes

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

@qingyun-wu qingyun-wu qingyun-wu approved these changes

@thinkall thinkall Awaiting requested review from thinkall

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RAG interpreter notebook for gptassistant
6 participants
@gagb @codecov-commenter @LeoLjl @IANTHEREAL @qingyun-wu @sonichi