[DownloadBuildArtifactsV0] Respect "Parallelization limit" input #14540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2021 11:23
- Add function to resolve `parallelProcessingLimit` value - Changed `configureDownloaderOptions` function to respect `Parallelization limit` input - Remove `timeoutPromise` function since not used in task
|
Test pipeline: link |
added 2 commits
March 5, 2021 13:34
…wnloadBuildArtifactsV0_respect_parallelization_limit_input
- Extract default value to constant - Fix code comments - Extract duplicate logic to separate function - Rework debug messages
anatolybolshakov
approved these changes
Mar 9, 2021
|
Tested on basic scenario also - 'Parallelization limit' input is respected for me now. |
added 2 commits
March 9, 2021 17:11
…wnloadBuildArtifactsV0_respect_parallelization_limit_input
egor-bryzgalov
approved these changes
Mar 9, 2021
EzzhevNikita
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
LGTM! Tested this changes manually, resolveParallelProcessingLimit logic work good for me. Test pipeline
added 2 commits
March 10, 2021 11:56
…wnloadBuildArtifactsV0_respect_parallelization_limit_input
…wnloadBuildArtifactsV0_respect_parallelization_limit_input
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name:
Description:
This PR provide a fix for the issue when the task didn't respect the
Parallelization limitinput.Changes:
resolveParallelProcessingLimitfunction to setParallelization limitvalueconfigureDownloaderOptionsfunction to respectParallelization limitinputOther changes:
timeoutPromisefunction since not used in taskDocumentation changes required: No
Added unit tests: No
Attached related issue:
Checklist: