Remove useless error log when use device login #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
reviewed
Jan 22, 2019
...res/azure-toolkit-for-intellij/src/com/microsoft/azuretools/ijidea/ui/DeviceLoginWindow.java
Outdated
Show resolved
Hide resolved
Eskibear
reviewed
Jan 22, 2019
...res/azure-toolkit-for-intellij/src/com/microsoft/azuretools/ijidea/ui/DeviceLoginWindow.java
Outdated
Show resolved
Hide resolved
wezhang
reviewed
Jan 22, 2019
...res/azure-toolkit-for-intellij/src/com/microsoft/azuretools/ijidea/ui/DeviceLoginWindow.java
Outdated
Show resolved
Hide resolved
SummerSun
reviewed
Mar 29, 2019
| break; | ||
| // Close adal logger for it will write useless error log | ||
| // for issue #2368 https://github.com/Microsoft/azure-tools-for-java/issues/2368 | ||
| Logger authLogger = Logger.getLogger(AuthenticationContext.class); |
andxu
pushed a commit
to andxu/azure-tools-for-java
that referenced
this pull request
Mar 24, 2020
* Remove useless error log when use device login * Close the correspond class logger instead of root logger * Put setLevel into try-catch closure to ensure log level will be restored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove waiting response error notification when use device login.
For issue #2368