Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zlib CVE-2023-45853 #6489

Closed
wants to merge 4 commits into from
Closed

Fix zlib CVE-2023-45853 #6489

wants to merge 4 commits into from

Conversation

liunan-ms
Copy link
Contributor

@liunan-ms liunan-ms commented Oct 19, 2023 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

What does the PR accomplish, why was it needed?
Fix CVE-2023-45853

Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@liunan-ms liunan-ms requested a review from a team as a code owner October 19, 2023 18:10
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Oct 19, 2023
@mfrw mfrw added the security label Oct 20, 2023
mfrw
mfrw approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think the test build failure is a known IMO

@liunan-ms
Copy link
Contributor Author

LGTM. I think the test build failure is a known IMO

Thanks @mfrw , I created a new PR for this change against fasttrack/2.0 branch as CVE-2023-4813 is critical, and close this PR.

@liunan-ms liunan-ms closed this Oct 20, 2023
@Neustradamus
Copy link

Linked to:

@jslobodzian jslobodzian deleted the liunan/zlib-CVE branch August 9, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrw mfrw mfrw approved these changes

Assignees
No one assigned
Labels
main PR Destined for main security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liunan-ms @Neustradamus @mfrw