Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

[SPIKE] Node Pool Support for Terraform AKS resource #417

Closed
bnookala opened this issue May 7, 2019 · 10 comments
Closed

[SPIKE] Node Pool Support for Terraform AKS resource #417

bnookala opened this issue May 7, 2019 · 10 comments
Assignees
Labels
effort - XL really needs to be broken up enhancement New feature or request infra-team needs-investigation on-hold operational Todo with the way the team operates

Comments

@bnookala
Copy link
Member

bnookala commented May 7, 2019

As a:

Cluster Operator

I want:

Node pool support in our terraform scripts

So that:

I can have multiple agent pools for my AKS cluster of varying VM SKUs, or (if i've reached my agent node limit per pool) have multiple agent pools of the same VM SKU.

Describe the solution you'd like:

An upstream terraform contribution to add node pool support to the AKS resource in the Azure terraform provider.

Additional context:

No existing work item exists in the upstream repository: https://github.com/terraform-providers/terraform-provider-azurerm/issues?utf8=%E2%9C%93&q=is%3Aissue+node+pool+

The google provider has a good way to implement node pool support: https://www.terraform.io/docs/providers/google/r/container_cluster.html

Does this require updates to documentation?:

Yes.

@bnookala bnookala added enhancement New feature or request effort - XL really needs to be broken up needs-investigation infra-team operational Todo with the way the team operates labels May 7, 2019
@brusMX
Copy link
Member

brusMX commented May 8, 2019

This is also important because inherently you are allowing VMSS and you will also put the first stone for Windows on AKS

@gled4er
Copy link

gled4er commented May 31, 2019

Hello @bnookala ,

Thank you for opening the issue!

I think this functionality will be very useful.

Let us know how we can help to prioritize.

Thank you!

@schefs
Copy link

schefs commented Jul 24, 2019

would like to have that feature also !
all my deployments are terraform based and we want to start using multiple node pool with terraform.
can't go to production without it.

@bnookala
Copy link
Member Author

bnookala commented Aug 29, 2019

The azure terraform resource provider now has node pool support hashicorp/terraform-provider-azurerm#3422 - we'll start work on getting a sample environment next

@bnookala bnookala self-assigned this Aug 29, 2019
@bnookala
Copy link
Member Author

Azure terraform provider is receiving a new resource to manage node pools independently allowing things like autoscaling - let's keep track of this while working on agent pool support independently: hashicorp/terraform-provider-azurerm#4001

In addition: hashicorp/terraform-provider-azurerm#3971 seems to be a present issue in the terraform provider, which should be noted.

@NathanielRose NathanielRose changed the title Node Pool Support for Terraform AKS resource [SPIKE] Node Pool Support for Terraform AKS resource Sep 9, 2019
@NathanielRose
Copy link
Contributor

NathanielRose commented Sep 9, 2019

[SPIKE] - Node pools w/availability zones (in Azure preview)

  • Can this be turned on & off
  • - A scaffold of the module in template
  • - Dependencies and Preview caveats
  • - Instructions with scaling in the cluster.

@NathanielRose
Copy link
Contributor

Updates for Node Pools added to Master terraform provider for azure - hashicorp/terraform-provider-azurerm@424e973
Needs testing then integration to Bedrock.

@jluk
Copy link

jluk commented Dec 19, 2019

FYI this was enabled in provider v 1.37 so this looks stale but I stumbled here from google 😄

https://www.terraform.io/docs/providers/azurerm/r/kubernetes_cluster_node_pool.html

@yradsmikham
Copy link
Contributor

@NathanielRose From the last comment, it appears that this may be resolved now?

@NathanielRose
Copy link
Contributor

Yes, @yradsmikham. Let's get a quick test log and doc proofing it out and this can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort - XL really needs to be broken up enhancement New feature or request infra-team needs-investigation on-hold operational Todo with the way the team operates
Projects
None yet
Development

No branches or pull requests

9 participants