Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Manifest diff as a PR comment for AzDO #1455

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

samiyaakhtar
Copy link
Contributor

@samiyaakhtar samiyaakhtar commented Mar 10, 2021

  • Added a helper function to the AzDO script to generate manifests and post a diff as a comment - see here for an example
  • Fixed a minor bug where downloading fabrikate would get into infinite loop when there's another downloaded archive from a previous job with the same name. Using a random uuid fixes this issue
  • Adding -q to silence the wget output which was taking up 90% of the output in logs, making it difficult to focus on the important logs generated by the scripts

Related to microsoft/spektate#155

@samiyaakhtar
Copy link
Contributor Author

@nmiodice I'm unable to request a review from you for some reason, but feel free to give any feedback here, I followed your template for Gitlab :)

gitops/azure-devops/build.sh Outdated Show resolved Hide resolved
@nmiodice
Copy link

@nmiodice I'm unable to request a review from you for some reason, but feel free to give any feedback here, I followed your template for Gitlab :)

Hey! I'm not a maintainer for this project so I won't be able to give a formal review on this. Looks like you got some feedback from the maintaining team, though. Happy to help if I can!

@andrebriggs
Copy link
Member

It would be good too see a larger diff so we can see what the user experience is like for large yaml diffs and (additions/subtraction)

@samiyaakhtar samiyaakhtar marked this pull request as draft March 10, 2021 22:43
@samiyaakhtar
Copy link
Contributor Author

Based on discussion with @andrebriggs, converting this to a draft and after testing with larger diffs, we will re-open this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants