Update GetValue to throw on error - HOLD #6604
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR updates the GetValue method in ExpressionProperty to throw when there's an invalid expression.
This was reported as part of an issue in Composer where an invalid expression was causing an error in JS while .NET was letting it pass.
This PR also fixes an issue in the ConfirmInput class where an invalid expression was being ignored.
Specific Changes
Testing
These images show the related unit tests passing after the changes.