[#6825] Fix Microsoft.Bcl.AsyncInterfaces warnings #6837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sw-joelmut
added
the
Automation: No parity
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll |
tracyboehrer
approved these changes
Aug 5, 2024
tracyboehrer
pushed a commit
that referenced
this pull request
Sep 9, 2024
# Conflicts: # libraries/Microsoft.Bot.Builder.Azure/Microsoft.Bot.Builder.Azure.csproj
tracyboehrer
added a commit
that referenced
this pull request
Sep 10, 2024
* Fix for Skills endorsement check (#6846) Co-authored-by: Tracy Boehrer <[email protected]> * FederatedAppCredentials and factory * add token credential authentication to BlobsTranscriptStore (#6813) * [#6741] Remove .Net Core 3.1 from projects (#6819) * Remove netcoreapp3.1 and fix System.Text.Json issue * Fix System.Formats.Asn1 security issue * Fix remaining System.Text.Json issue * Removed unused argument from FederatedAuthenticator.CreateClientApplication * Fix Microsoft.Bcl.AsyncInterfaces warning (#6837) # Conflicts: # libraries/Microsoft.Bot.Builder.Azure/Microsoft.Bot.Builder.Azure.csproj * add code ql comment about TypeNameHandling.None (#6843) --------- Co-authored-by: Tracy Boehrer <[email protected]> Co-authored-by: Jhonatan Sandoval Velasco <[email protected]> Co-authored-by: Joel Mut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6825
#minor
Description
This PR adds the
Microsoft.Bcl.AsyncInterfacespackage toMicrosoft.Bot.Builder.Azureproject, forcing 1.x version to 8.x, solving the MSB3277 warnings.Specific Changes
Microsoft.Bcl.AsyncInterfacestoMicrosoft.Bot.Builder.Azureproject, forcing to use 8.x version instead of 1.x that caused the conflict.System.Diagnostics.DiagnosticSourceinMicrosoft.Bot.Builder.Integration.ApplicationInsights.WebApiproject, solving MSB3245 warning.Testing
The following images show the CI pipeline, and the reduction of the warnings.
