Skip to content

Commit

Permalink
fix: Critical alert for es5-ext 0.10.60 (#4198)
Browse files Browse the repository at this point in the history
* Override "es5-ext" back to "0.10.53"

* Add component detection
  • Loading branch information
BruceHaley authored Apr 19, 2022
1 parent 6210431 commit 7af7ef2
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
11 changes: 7 additions & 4 deletions testing/streaming-e2e/build/create-react-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,27 @@ steps:
workingDirectory: $(ReactProjectDir)

- template: customize-dljs.yml

- powershell: npm install $(DLJSDir)/botframework-directlinejs.tgz
displayName: 'npm install botframework-directlinejs.tgz'
workingDirectory: $(ReactProjectDir)

- powershell: |
Rename-Item ./botframework-directlinejs botframework-directlinejs.old
Rename-Item ./botframework-streaming botframework-streaming.old
ls
displayName: Rename DLJS node modules
workingDirectory: $(ReactProjectDir)/node_modules/botframework-webchat/node_modules
- powershell: npm run build
displayName: Build React App
workingDirectory: $(ReactProjectDir)

- task: PublishPipelineArtifact@1
displayName: 'Publish Artifact: ReactApp'
inputs:
targetPath: $(ReactProjectDir)/build
artifactName: 'ReactApp'

- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
displayName: 'Component Detection'
5 changes: 4 additions & 1 deletion testing/streaming-e2e/react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
"botframework-webchat": "4.10.1",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-scripts": "3.4.3"
"react-scripts": "^4.0.3"
},
"overrides": {
"es5-ext": "0.10.53"
},
"scripts": {
"start": "react-scripts start",
Expand Down

0 comments on commit 7af7ef2

Please sign in to comment.