Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Corrected GetConversationMembers to use TeamsInfo helper class rather… (#5874) #3922

Closed
github-actions bot opened this issue Sep 3, 2021 · 2 comments · Fixed by #4151
Closed

port: Corrected GetConversationMembers to use TeamsInfo helper class rather… (#5874) #3922

github-actions bot opened this issue Sep 3, 2021 · 2 comments · Fixed by #4151
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms.
Milestone
R16

Comments

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

The changes in Corrected GetConversationMembers to use TeamsInfo helper class rather… (#5874) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

… than rely on BotFrameworkAdapter directly.

Fixes #5873

Description

Corrected GetConversationMembers in Adaptive.Runtime to use TeamsInfo helper class rather than rely on BotFrameworkAdapter functions that aren't available now that CoreBotAdapter derives from CloudAdapter and not BotFrameworkAdapter

Specific Changes

Remove check for BotFrameworkAdapter and call to it for GetConversationMembersAsync and now use TeamsInfo and call GetMembersAsync.

Testing

Tested against a Composer created bot using the updated SDK to make sure all the changes were correct.

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Sep 3, 2021
@mrivera-ms mrivera-ms added the P1 Painful if we don't fix, won't block releasing label Mar 3, 2022
@mrivera-ms
Copy link
Contributor

Assigning to @JuanAr for investigation. We need to establish if this is needed in JS.

@mrivera-ms mrivera-ms added this to the R16 milestone Mar 3, 2022
@ceciliaavila
Copy link
Collaborator

@mrivera-ms in progress

mraitersw added a commit to southworks/botbuilder-js that referenced this issue Mar 9, 2022
@mraitersw
Merge pull request #261 from southworks/southworks/port/correct-getCo…
8cdfa35 
…nversationMembers-to-use-teaminfo

port: [microsoft#3922] Corrected GetConversationMembers to use TeamsInfo helper class rather… (#5874)
@ceciliaavila ceciliaavila mentioned this issue Mar 9, 2022
Merged
mrivera-ms added a commit that referenced this issue Mar 17, 2022
@ceciliaavila @mraitersw
@mrivera-ms @EricDahlvang
port: [#3922] Corrected GetConversationMembers to use TeamsInfo helpe…
9fa659c 
…r class rather… (#5874) (#4151)

* Remove functions from BotFrameworkAdapter

* add library, so it can fix yarn depcheck

* apply changes

Co-authored-by: mraitersw <[email protected]>
Co-authored-by: Monica Rivera <[email protected]>
Co-authored-by: Eric Dahlvang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. P1 Painful if we don't fix, won't block releasing parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
R16
3 participants
@JuanAr @ceciliaavila @mrivera-ms