Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Catch HttpRequestException in HttpRequest (#6404) #4277

Closed
github-actions bot opened this issue Jul 11, 2022 · 1 comment · Fixed by #4304
Closed

port: Catch HttpRequestException in HttpRequest (#6404) #4277

github-actions bot opened this issue Jul 11, 2022 · 1 comment · Fixed by #4304
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in Catch HttpRequestException in HttpRequest (#6404) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6403

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jul 11, 2022
@tracyboehrer
Copy link
Member

@ceciliaavila @JuanAr Can you verify if this port is required in JavaScript? If not, the issue can be closed.

@ceciliaavila ceciliaavila mentioned this issue Aug 3, 2022
Merged
ceciliaavila added a commit to southworks/botbuilder-js that referenced this issue Aug 12, 2022
@ceciliaavila
port: [microsoft#4277] Catch HttpRequestException in HttpRequest (#64…
c692c81 
…04) (microsoft#4304)

* HttpRequest class updated. Unit test created.

* Added botbuilder-core dependency.

Co-authored-by: Emiliano Quiroga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4277] Catch HttpRequestException in HttpRequest (#6404) microsoft/botbuilder-js
2 participants
@JuanAr @tracyboehrer