Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Support passing sas token url's for token service (#6449) #4315

Closed
github-actions bot opened this issue Aug 24, 2022 · 0 comments · Fixed by #4394
Closed

port: Support passing sas token url's for token service (#6449) #4315

github-actions bot opened this issue Aug 24, 2022 · 0 comments · Fixed by #4394
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in Support passing sas token url's for token service (#6449) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #minor N/A

Description

This PR introduces support for passing through a token post resource via botbuilder. The token post resource contains a sas url for directly posting a token from a client to the bot framework token service. Botbuilder gets this url from token service and passes it onto the client.

Specific Changes

  • Add support for token post resource
  • Support optional token post resource inside oauthcard

Testing

  • Added unit tests

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Aug 24, 2022
@NahuelPerales NahuelPerales mentioned this issue Dec 16, 2022
Closed
@ceciliaavila ceciliaavila mentioned this issue Dec 20, 2022
Merged
tracyboehrer pushed a commit that referenced this issue Jan 4, 2023
@ceciliaavila @NahuelPerales
port: [#4315] Support passing sas token url's for token service (#644…
c315e7b 
…9) (#4394)

* add sas url token support

* Update api.md files

Co-authored-by: Nahuel Perales <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4315] Support passing sas token url's for token service (#6449) microsoft/botbuilder-js
1 participant
@JuanAr