[bf-streaming] Web Socket disconnected should rejects all ongoing requests

[compulim]

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Versions

What package version of the SDK are you using.
4.19.3

What nodejs version are you using
18

What browser version are you using
No

What os are you using
Ubuntu

Describe the bug

RequestManager keep tracks of all outgoing requests. More-or-less the call manager of RPC.

When a Web Socket disconnected, botframework-streaming does not signal RequestManager to reject all pending requests. Thus, all pending requests are kept forever and never returned.

One failing case, after Web Socket disconnected, C2 can still send an activity. For that send request, despite it is disconnected and should fail, were never rejected and just keep on forever.

To Reproduce

Steps to reproduce the behavior:

1. Instantiate DirectLineStreaming via botframework-directlinejs package
2. Call postActivity()
3. Before the message is put on the Web Socket connection, kill the connection

Expected behavior

postActivity() should fail.

However, it is not failing because NodeWebSocketClient and BrowserWebSocketClient did not tell RequestManager about the disconnection.

While we can say NodeWebSocketClient/BrowserWebSocketClient should signal disconnection, however, RequestManager has no public members to reject all pending requests.

Even worse, the requests at RequestManager._pendingRequests are not rejectable. There are no way to call pendingRequest.reject() function.

That means, no requests can be rejected regardless of whatever situation. This means, either a request resolved, or keep on forever.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.