Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#3874] Parity issue with getContinuationActivity method missing the type property #3875

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix: [#3874] Parity issue with getContinuationActivity method missing the type property #3875

merged 1 commit into from
Jul 21, 2021

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #3874

Description

This PR fixes a parity issue in the getContinuationActivity method, adding the missing type property that its DotNet counterpart has (link). Otherwise when the ActivityHandler.run method is executed will validate and throw the Activity is missing its type error when the type property is not found in the Activity.

Specific Changes

  • Added the type property to be an ActivityTypes.Event in the getContinuationActivity method.

@sw-joelmut sw-joelmut requested a review from a team as a code owner July 20, 2021 19:59
mdrichardson
mdrichardson approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@mdrichardson mdrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Here's the implementation in .NET, FYI for other reviewers.

@mdrichardson mdrichardson changed the title [#3874] Parity issue with getContinuationActivity method missing the type property fix: [#3874] Parity issue with getContinuationActivity method missing the type property Jul 20, 2021
@coveralls
Copy link

coveralls commented Jul 20, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1050156224

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.342%
Totals Coverage Status
Change from base Build 1046054717: 0.0%
Covered Lines: 19685
Relevant Lines: 22143
💛 - Coveralls

@joshgummersall
Copy link
Contributor

Thanks, @sw-joelmut! Much appreciated.

@joshgummersall joshgummersall merged commit 02eaa8f into microsoft:main Jul 21, 2021
@sw-joelmut sw-joelmut deleted the southworks/fix/continuation-activity-parity branch September 21, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parity issue with getContinuationActivity method missing the type property
4 participants
@sw-joelmut @coveralls @joshgummersall @mdrichardson