fix: [#2745] Fix current eslint warnings - adaptive-expressions library (2/2) #4035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2745
#minor
Description
This PR fixes the ESLint and JSDoc issues in the adaptive-expressions library.
Note: we excluded the
@typescript-eslint/no-explicit-any
and@typescript-eslint/explicit-module-boundary-types
to tackle those issues as a separated task as they require deeper analysis and testing.Specific Changes
yarn lint --fix
(quotes, spacing, replaced var with let)@typescript-eslint/ban-types
rule to review the use of object along with the any types.security/detect-non-literal-regexp
rule as the variables are needed to create the regex dynamically.requires
to the import section.Testing
This image shows the tests passing after the changes.