Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2745] Fix current eslint warnings - adaptive-expressions library (2/2) #4035

Merged
merged 8 commits into from
Feb 1, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Addresses #2745
#minor

Description

This PR fixes the ESLint and JSDoc issues in the adaptive-expressions library.

Note: we excluded the @typescript-eslint/no-explicit-any and @typescript-eslint/explicit-module-boundary-types to tackle those issues as a separated task as they require deeper analysis and testing.

Specific Changes

  • Applied the eslint auto-fix with yarn lint --fix (quotes, spacing, replaced var with let)
  • Added missing JSDoc documentation in methods.
  • Removed unused imports and variables.
  • Disabled @typescript-eslint/ban-types rule to review the use of object along with the any types.
  • Disabled security/detect-non-literal-regexp rule as the variables are needed to create the regex dynamically.
  • Moved variables with requires to the import section.

Testing

This image shows the tests passing after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner December 30, 2021 17:05
@coveralls
Copy link

coveralls commented Dec 30, 2021

Pull Request Test Coverage Report for Build 1775419150

  • 3 of 13 (23.08%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 84.545%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/adaptive-expressions/src/memory/simpleObjectMemory.ts 0 1 0.0%
libraries/adaptive-expressions/src/datetimeFormatConverter.ts 0 4 0.0%
libraries/adaptive-expressions/src/functionTable.ts 0 5 0.0%
Totals Coverage Status
Change from base Build 1775406937: -0.04%
Covered Lines: 19667
Relevant Lines: 22035

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit ba638f1 into main Feb 1, 2022
@mrivera-ms mrivera-ms deleted the southworks/fix/eslint/adaptive-expressions-2 branch February 1, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants