fix: Change component detection scan path to root #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1726583624
💛 - Coveralls |
munozemilio
approved these changes
Jan 21, 2022
BruceHaley
added
the
Area: Engineering
mrivera-ms
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #minor
Description
This changes the Component Detection scan area to include the yarn.lock file at the root. I believe those dependencies should be included in the Component Detection scanning process.
Specific Changes
Delete the sourceScanPath input line so scanning includes the yarn.lock file at the root.
Add ./generators to the ignoreDirectories list because that is currently scanned in the pipeline BotBuilder-Generators-JS-daily.