Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4039] Teams now supports <= 50 Card Actions (#6085) #4158

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4039

Description

This PR ports the changes in BotBuilder-DotNet's PR#6085 to add support for <= 50 Card Actions on teams.

Specific Changes

  • Updated channel.ts to support <= 50 Card Actions on teams.
  • Added unit tests in choices_channel.test.js to cover the different test cases.

Testing

This image shows the new unit tests passing.
2022-03-11 16_04_15-PowerShell 7 (x64)

@ceciliaavila ceciliaavila requested a review from a team as a code owner March 11, 2022 19:57
@coveralls
Copy link

coveralls commented Mar 11, 2022

Pull Request Test Coverage Report for Build 1970737983

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 84.547%

Totals Coverage Status
Change from base Build 1955117631: -0.2%
Covered Lines: 19670
Relevant Lines: 22038

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 3bcc47f into main Mar 11, 2022
@mrivera-ms mrivera-ms deleted the southworks/port/teams-now-supports-50-card-actions branch March 11, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Teams now supports <= 50 Card Actions (#6085)
4 participants