Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4092] Add ActivityTypeProperty to TelemetryLoggerMiddleware #4160

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4092

Description

This PR adds the activityTypeProperty into the TelemetryConstants class, also adds the missing documentation for the rest of the properties. Additionally, it adds the type property to the TelemetryLoggerMiddleware receive, update and delete events, and updates the unit tests.

Specific Changes

  • Adds the activityTypeProperty into the TelemetryConstants class.
  • Adds the missing property comments in the TelemetryConstants class.
  • Adds the property to the TelemetryLoggerMiddleware receive, update and delete events.
  • Updates the unit tests to support the new property.

Testing

The following image shows the tests passing successfully.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner March 16, 2022 12:05
@coveralls
Copy link

coveralls commented Mar 16, 2022

Pull Request Test Coverage Report for Build 1995461312

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 84.573%

Totals Coverage Status
Change from base Build 1995456056: -0.002%
Covered Lines: 19707
Relevant Lines: 22073

💛 - Coveralls

@EricDahlvang EricDahlvang merged commit 7db3aeb into main Mar 16, 2022
@EricDahlvang EricDahlvang deleted the southworks/add/activity-type-property branch March 16, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Add ActivityTypeProperty to TelemetryLoggerMiddleware (#6028)
3 participants