Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [#3518] Remove public access modifier from botbuilder-dialogs #4217

Merged
merged 2 commits into from
Jun 15, 2022
Merged

chore: [#3518] Remove public access modifier from botbuilder-dialogs #4217

merged 2 commits into from
Jun 15, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #3518
#minor

Description

This PR removes the public access modifier from all constructors, methods and properties for the botbuilder-dialogs folder.

Note: These changes do not include the Typescript Constructor Shorthands (link).

Specific Changes

  • Removes all public access modifiers from where it's declared under the botbuilder-dialogs folder.

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 2, 2022 14:18
@coveralls
Copy link

coveralls commented May 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2258446027

  • 40 of 40 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.48%
Totals Coverage Status
Change from base Build 2245574340: -0.003%
Covered Lines: 19902
Relevant Lines: 22310
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 36e60fc into main Jun 15, 2022
@tracyboehrer tracyboehrer deleted the southworks/delete/public-botbuilder-dialogs branch June 15, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sw-joelmut @coveralls @tracyboehrer