Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4204] Fix remaining eslint warnings - botframework-config #4234

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

sw-joelmut
Copy link
Collaborator

@sw-joelmut sw-joelmut commented May 5, 2022

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botframework-config library.

Note: we excluded the @typescript-eslint/no-explicit-any and @typescript-eslint/explicit-module-boundary-types to tackle those issues as a separate task, as they require deeper analysis and testing.

Specific Changes

  • Applied auto-fixes with yarn lint --fix
    • Add a blank line in between comments.
    • Fix spacing.
    • Fix quoting.
    • Replace arrow functions: () => with function ().
    • Replace let with const.
  • Applied manual fixes for:
    • Missing documentation.
    • Unused parameters and imports.
    • Replacing hasOwnProperty calls.
    • Removed unused catch error variables.
    • Updated methods documentation in botframework-config.md.

Testing

Here we can see the ESLint status before and after.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 5, 2022 14:29
@coveralls
Copy link

coveralls commented May 5, 2022

Pull Request Test Coverage Report for Build 2656852314

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 84.478%

Totals Coverage Status
Change from base Build 2656737347: -0.005%
Covered Lines: 19900
Relevant Lines: 22308

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 8ec3563 into main Jul 13, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botframework-config branch July 13, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants