Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4204] Fix remaining eslint warnings - botbuilder-lg #4235

Merged
merged 9 commits into from
Jul 13, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder-lg library.

Specific Changes

  • Applied auto-fixes with yarn lint --fix.
    • Add trailing commas
    • Fix spacing.
    • Fix indentation.
    • Add blank line in between comments.
    • Fix quoting.
    • Replace arrow functions: () => with function ().
    • Replace let with const.
  • Applied manual fixes for:
    • Missing documentation.
    • Unused parameters and imports.
    • Replacing hasOwnProperty calls.
    • Fixing lodash imports.

Testing

image

image

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 12, 2022 16:35
@coveralls
Copy link

coveralls commented May 12, 2022

Pull Request Test Coverage Report for Build 2656868923

  • 43 of 45 (95.56%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.479%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-lg/src/multiLanguageLG.ts 0 1 0.0%
libraries/botbuilder-lg/src/templatesParser.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 2656737347: -0.003%
Covered Lines: 19904
Relevant Lines: 22312

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 5c1d429 into main Jul 13, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-botbuilder-lg branch July 13, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants