Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#4204] Fix remaining eslint warnings - Rest of botbuilder-dialogs libraries - botbuilder declarative #4238

Merged
merged 3 commits into from
Jul 13, 2022
Merged

fix: [#4204] Fix remaining eslint warnings - Rest of botbuilder-dialogs libraries - botbuilder declarative #4238

merged 3 commits into from
Jul 13, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4204
#minor

Description

This PR fixes the ESLint and JSDoc issues in the botbuilder-dialogs-declarative library.

Specific Changes

  • Applied auto-fixes with yarn lint --fix
    • Fix spacing
    • Fix indentation
    • Add blank line in between comments
    • Add trailing commas
    • Missing parameters in descriptions
  • Applied manual fixes for:
    • Missing documentation
    • Unnecessary escape characters
    • Disabling detect-non-literal-fs-filename rule to allow dynamic path for files

Testing

Library eslint status
Screenshot 2022-05-04 114924

Test:compat
Screenshot 2022-05-04 114905

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 12, 2022 16:39
@coveralls
Copy link

coveralls commented May 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2656937665

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.479%
Totals Coverage Status
Change from base Build 2656737347: -0.003%
Covered Lines: 19904
Relevant Lines: 22312
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit bc668f6 into main Jul 13, 2022
@tracyboehrer tracyboehrer deleted the southworks/fix/eslint-rest-of-botbuilder-dialogs-declarative branch July 13, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sw-joelmut @coveralls @tracyboehrer @ceciliaavila