Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update TypeScript Version in Yeoman Templates to 4.0.7 #4257

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

anishprasad01
Copy link
Contributor

Fixes #4251

Description

Updates the TypeScript version of the generators for empty, echo, and core bot templates to the earliest supported version, 4.0.7, to resolve the bug.

Specific Changes

  • Update TS version package.json.ts and package-with-tests.json.ts in core bot template from 3.9.2 to 4.0.7.
  • Update TS version package.json.ts in echo bot template from 3.9.2 to 4.0.7.
  • Update TS version package.json.ts in empty bot template from 3.9.2 to 4.0.7.

Testing

npm install fails on version 3.9.2. Updating the version and rerunning the install results in a success and the bot then runs.

@anishprasad01 anishprasad01 added the Automation: No parity PR does not need to be applied to other languages. label Jun 3, 2022
@anishprasad01 anishprasad01 requested a review from gabog June 3, 2022 18:50
@anishprasad01 anishprasad01 requested a review from a team as a code owner June 3, 2022 18:50
@anishprasad01 anishprasad01 self-assigned this Jun 3, 2022
@anishprasad01 anishprasad01 changed the title Fix: Update TypeScript Version in Yeoman Templates to 4.0.7 fix: Update TypeScript Version in Yeoman Templates to 4.0.7 Jun 3, 2022
@coveralls
Copy link

coveralls commented Jun 3, 2022

Pull Request Test Coverage Report for Build 2436508762

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.481%

Totals Coverage Status
Change from base Build 2415522468: 0.0%
Covered Lines: 19903
Relevant Lines: 22311

💛 - Coveralls

@gabog gabog merged commit d6a12cd into main Jun 3, 2022
@gabog gabog deleted the anishprasad01/yeoman-ts-version-fix branch June 3, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build TypeScript OOTB Echo BOT
3 participants