fix: [#4408] Cloud adapter is not working with teams SSO #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4104699408
💛 - Coveralls |
johnataylor
approved these changes
Feb 8, 2023
johnataylor
deleted the
southworks/fix/cloudAdapter-is-not-working-with-teamsSSO
branch
tracyboehrer
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Updated teamsSSOTokenExchangeMiddleware.ts * Updated wrong provided token message * Code improvements * Suggested changes applied * Added unit tests. --------- Co-authored-by: Emiliano Quiroga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4408
Description
This PR allows the SSO Teams bots to work with CloudAdapter. It also adds the unit tests for the different adapter cases.
Specific Changes
Testing
Added unit tests for the exchangedToken method.
