New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#4455] [botframework-streaming] Tests are not conclusive #4468

Merged

tracyboehrer merged 1 commit into main from southworks/update/multiple-done

May 5, 2023

Collaborator

sw-joelmut commented Apr 28, 2023

Fixes #4455

Description

This PR modifies and removes unnecessary done function calls from all unit tests.

Specific Changes

Redundant done function calls have been removed to use only one.
Removed done function calls where wasn't necessary.


          Update and remove unnecessary done function calls

90c6011

sw-joelmut requested a review from a team as a code owner

April 28, 2023 13:22

coveralls commented Apr 28, 2023 •

edited

Loading

Pull Request Test Coverage Report for Build 4831092402

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 84.729%

Totals
Change from base Build 4792156003:	0.4%
Covered Lines:	20035
Relevant Lines:	22409

💛 - Coveralls

tracyboehrer approved these changes

View reviewed changes

tracyboehrer merged commit d086767 into main

tracyboehrer deleted the southworks/update/multiple-done branch

May 5, 2023 13:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet