Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ASE channel validation. #4589

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

fangyangci
Copy link
Contributor

@fangyangci fangyangci commented Dec 18, 2023

Fixes #6719
C# PR #6718

Description

To resolve the connection issue between DL_ASE and bot, we built DL_ASE v2.0. In v2.0, we used WebSocket/HTTPS instead of named pipe to connect between DL_ASE and bot.

Therefore, we need to add a special header validation for AseChannel.

Specific Changes

Add AseChannel channelId check in ConfigurationBotFrameworkAuthentication.

Testing

Adding unit tests in JwtTokenValidationTests.
Test locally with plulic/usgove singletenant/multitenant/umsi

@fangyangci fangyangci requested a review from a team as a code owner December 18, 2023 14:09
@tracyboehrer tracyboehrer changed the title Add ase channel validation fix: Add ASE channel validation Dec 18, 2023
@coveralls
Copy link

coveralls commented Dec 18, 2023

Pull Request Test Coverage Report for Build 7256924717

  • 62 of 90 (68.89%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 84.539%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-connector/src/auth/jwtTokenValidation.ts 3 4 75.0%
libraries/botframework-connector/src/auth/msalServiceClientCredentialsFactory.ts 0 1 0.0%
libraries/botframework-connector/src/auth/parameterizedBotFrameworkAuthentication.ts 1 3 33.33%
libraries/botframework-connector/src/auth/aseChannelValidation.ts 27 51 52.94%
Totals Coverage Status
Change from base Build 7132486847: -0.09%
Covered Lines: 20416
Relevant Lines: 22873

💛 - Coveralls

@fangyangci fangyangci changed the title fix: Add ASE channel validation Add ASE channel validation. Dec 19, 2023
@fangyangci fangyangci changed the title Add ASE channel validation. feat: Add ASE channel validation. Dec 19, 2023
@tracyboehrer tracyboehrer merged commit c1a71ae into microsoft:main Dec 21, 2023
13 of 14 checks passed
tracyboehrer pushed a commit that referenced this pull request Jan 24, 2024
* aseChannelValidation

* fix usgov single tenant

* fix js lint

* fix js lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants