fix: [#4582] UserAssignedIdentity(WorkloadIdentity) auth fails with 'scope https://api.botframework.com is not valid' #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7613456265
💛 - Coveralls |
tracyboehrer
approved these changes
Jan 24, 2024
tracyboehrer
pushed a commit
that referenced
this pull request
Jan 24, 2024
…scope https://api.botframework.com is not valid' (#4607) * Add scope post-fix in managedIdentityAuthenticator. * Fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4582
Description
This PR adds the
/.defaultsuffix to the scope for MSI authentication.Specific Changes
ManagedIdentityAuthenticatorto add the suffix to the scope.Testing
These images show the fix working with a bot deployed in AKS and another one deployed in an Azure App Service.
