Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [#4684] Replace browserify with tsup #4774

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR removes browserify from the repo and replaces it with tsup.

Specific Changes

  • Moved the existing tsup config from botframework-connector to the root of the repo, to be shared among all libraries.
  • Replaced browserify dependency from botframework-streaming, adaptive-expressions and adaptive-expressions-ie11 with tsup, removing unnecessary dependencies and scripts.
  • Removed babel-traverse resolution, as esmify was removed and no longer necessary.

Testing

The following image shows the browser import logs, and the browser-echo-bot working.
image
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner October 21, 2024 13:04
@coveralls
Copy link

coveralls commented Oct 21, 2024

@tracyboehrer tracyboehrer merged commit 84dc7e4 into main Oct 29, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/tsup-adaptive-expressions branch October 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants