Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort Activity Types and add Delay activity #4775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lord-maestro-encora
Copy link

Description

  • Activity Types enum are not sorted. Harder to look what exists or not. Also documentation was not sorted either.

  • Delay activity was not set into the Activity Types enum. I had to hardcode the string in my code or set as a constant at project level

Specific Changes

  • Activity Types enum is now sorted. And is clearer to look what exists or not. Documentation for the struct is also sorted trying to keep ~ 80 cols per line.

  • Delay activity was added. We will not need to write string or set a constant at project level

@lord-maestro-encora lord-maestro-encora requested a review from a team as a code owner October 22, 2024 19:51
@lord-maestro-encora
Copy link
Author

@microsoft-github-policy-service agree

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11467475449

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 84.891%

Totals Coverage Status
Change from base Build 11237135309: -0.4%
Covered Lines: 20363
Relevant Lines: 22943

💛 - Coveralls

Copy link
Collaborator

@ceciliaavila ceciliaavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the lint error and the yarn test:compat that is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants